Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Filepicker, Repositories
    • Labels:

      Description

      Viewing the filepicker on Windows, the appearance of the filepicker dialogue differs from the appearance in other browsers. Specifically:

      • The dialogue title bar is dark blue with unreadable text (this is also the case with the new Activity Chooser, so I assume it's a YUI related problem; and
      • The name of each repository appears below the repository icon instead of next to it. In the code the string appears twice.

      I will attach screenshots.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              Looks like a duplicate of MDL-33163

              Show
              poltawski Dan Poltawski added a comment - Looks like a duplicate of MDL-33163
              Hide
              salvetore Michael de Raadt added a comment -

              Hi, Dan.

              Yes, this is partly true. The positioning of the repository naming is different, though.

              Show
              salvetore Michael de Raadt added a comment - Hi, Dan. Yes, this is partly true. The positioning of the repository naming is different, though.
              Hide
              marina Marina Glancy added a comment -

              those all issues should be fixed by MDL-32764 . But I could not understand yet how YUI skins can be added to moodle. We will try to do it ASAP

              Show
              marina Marina Glancy added a comment - those all issues should be fixed by MDL-32764 . But I could not understand yet how YUI skins can be added to moodle. We will try to do it ASAP
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Hi guys,

              Just noting that styling YUI components generically as has been done for .yui3-widget-hd and a couple of other rules in that same area is REALLY bad.
              Those rules not only affect the file picker/manager but all the other places using any YUI widgets (overlays, panels, etc).
              You must always include something from the area you are styling in the selector in order to avoid this.
              I see this patch in fact fixes most of these so no probs now, but please for the future keep that in mind.

              Also using !important is bad but I think that message may have been passed on as well.

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Hi guys, Just noting that styling YUI components generically as has been done for .yui3-widget-hd and a couple of other rules in that same area is REALLY bad. Those rules not only affect the file picker/manager but all the other places using any YUI widgets (overlays, panels, etc). You must always include something from the area you are styling in the selector in order to avoid this. I see this patch in fact fixes most of these so no probs now, but please for the future keep that in mind. Also using !important is bad but I think that message may have been passed on as well. Cheers Sam
              Hide
              poltawski Dan Poltawski added a comment -

              The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

              TIA and ciao

              Show
              poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
              Hide
              poltawski Dan Poltawski added a comment -

              I've integrated this now, thanks.

              Show
              poltawski Dan Poltawski added a comment - I've integrated this now, thanks.
              Hide
              phalacee Jason Fowler added a comment -

              looks good on my Win7 IE9 instance

              Show
              phalacee Jason Fowler added a comment - looks good on my Win7 IE9 instance
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.

              Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.

              Many thanks for your collaboration!

              Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3. Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish. Many thanks for your collaboration! Ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12