Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.3
-
Fix Version/s: 2.3
-
Component/s: AJAX and JavaScript
-
Labels:None
-
Testing Instructions:
- Open a Course
- Turn Editing on
- Open the chooser dialogue
- Confirm that you can move the dialogue around by dragging it's header
-
Affected Branches:MOODLE_23_STABLE
-
Fixed Branches:MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-33292-master-3 -
Pull Master Diff URL:
Description
One of the requested features of the module chooser has been to make it possible to move the chooser around the screen.
It should be possible to do this in either:
- plug in the modchooser.js code; or
- plug in the chooserdialogue.js code for all chooser dialogues; or
- plug in the notification.js code to allow for any Dialogue or anything it extends (including chooserdialogue and thus modchooser).
Gliffy Diagrams
Issue Links
Activity
Looks nice to me, I have also verified this feature as used it for MDL-33191 testing.
Show
Ruslan Kabalin
added a comment - Looks nice to me, I have also verified this feature as used it for MDL-33191 testing.
Turns out that MDL-33192 didn't quite address all of the issues.
Show
Andrew Nicols
added a comment - Turns out that MDL-33192 didn't quite address all of the issues.
Just added the move cursor to the title bar to let people know it can be moved
Show
Andrew Nicols
added a comment - Just added the move cursor to the title bar to let people know it can be moved
Looks good, +1 for integration.
Show
Ruslan Kabalin
added a comment - Looks good, +1 for integration.
Integrated, thanks
Show
Dan Poltawski
added a comment - Integrated, thanks
Tested in multiple browsers, including Safari - and surprisingly it works!
Show
Dan Poltawski
added a comment - Tested in multiple browsers, including Safari - and surprisingly it works!
(including mobilesafari, you can drag with finger)
Show
Dan Poltawski
added a comment - (including mobilesafari, you can drag with finger)
Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL
Ciao 
Show
Eloy Lafuente (stronk7)
added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL
Ciao
I've done this as two commits. One adds the capability to the Dialogue and attaches the handler to the dialogue header.
The other consumes that for all chooser dialogues.
This isn't a MUST for 2.3 and can wait for 2.4 but I wanted to do this before it slips down my priority listings.