Moodle
  1. Moodle
  2. MDL-33292

Add ability to drag/drop the chooser dialogues (module chooser)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: AJAX and JavaScript
    • Labels:
      None
    • Rank:
      41140

      Description

      One of the requested features of the module chooser has been to make it possible to move the chooser around the screen.

      It should be possible to do this in either:

      • plug in the modchooser.js code; or
      • plug in the chooserdialogue.js code for all chooser dialogues; or
      • plug in the notification.js code to allow for any Dialogue or anything it extends (including chooserdialogue and thus modchooser).

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          I've done this as two commits. One adds the capability to the Dialogue and attaches the handler to the dialogue header.
          The other consumes that for all chooser dialogues.

          This isn't a MUST for 2.3 and can wait for 2.4 but I wanted to do this before it slips down my priority listings.

          Show
          Andrew Nicols added a comment - I've done this as two commits. One adds the capability to the Dialogue and attaches the handler to the dialogue header. The other consumes that for all chooser dialogues. This isn't a MUST for 2.3 and can wait for 2.4 but I wanted to do this before it slips down my priority listings.
          Hide
          Ruslan Kabalin added a comment -

          Looks nice to me, I have also verified this feature as used it for MDL-33191 testing.

          Show
          Ruslan Kabalin added a comment - Looks nice to me, I have also verified this feature as used it for MDL-33191 testing.
          Hide
          Andrew Nicols added a comment -

          Turns out that MDL-33192 didn't quite address all of the issues.

          Show
          Andrew Nicols added a comment - Turns out that MDL-33192 didn't quite address all of the issues.
          Hide
          Andrew Nicols added a comment -

          Just added the move cursor to the title bar to let people know it can be moved

          Show
          Andrew Nicols added a comment - Just added the move cursor to the title bar to let people know it can be moved
          Hide
          Ruslan Kabalin added a comment -

          Looks good, +1 for integration.

          Show
          Ruslan Kabalin added a comment - Looks good, +1 for integration.
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks

          Show
          Dan Poltawski added a comment - Integrated, thanks
          Hide
          Dan Poltawski added a comment -

          Tested in multiple browsers, including Safari - and surprisingly it works!

          Show
          Dan Poltawski added a comment - Tested in multiple browsers, including Safari - and surprisingly it works!
          Hide
          Dan Poltawski added a comment -

          (including mobilesafari, you can drag with finger)

          Show
          Dan Poltawski added a comment - (including mobilesafari, you can drag with finger)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: