Moodle
  1. Moodle
  2. MDL-33296

Remove the base directory '0' when downloading all as a zip.

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: STABLE backlog
    • Component/s: My home
    • Labels:
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      In My Private files, when downloading the zip file with the "Download all" link, a zip is successfully created.
      When opening this zip file there is a folder that shouldn't exist.

      Steps to reproduce:
      Navigate to My Private Files
      Create a folder
      Upload a file to this folder
      Click on "Save changes"
      Navigate to the main folder
      Click on "Download all"
      Open the zip file
      Navigate to the created folder
      There is another folder in the zip file that shouldn't exist.

        Gliffy Diagrams

          Issue Links

            Activity

            Ted van den Brink created issue -
            Ted van den Brink made changes -
            Field Original Value New Value
            Labels mdlqa
            Ted van den Brink made changes -
            Attachment result zip.png [ 28292 ]
            Attachment Folder contents.PNG [ 28293 ]
            Ted van den Brink made changes -
            Link This issue blocks MDLQA-2367 [ MDLQA-2367 ]
            moodle.com made changes -
            Assignee moodle.com [ moodle.com ] Adrian Greeve [ abgreeve ]
            Hide
            Adrian Greeve added a comment -

            Thanks Ted for spotting this issue. I've changed the status of this from a bug to an improvement so as to not block the completion of QA testing. The file system does remain intact and the files are not corrupted, it would be nice however to remove the base folder.

            Thanks again,

            Adrian.

            Show
            Adrian Greeve added a comment - Thanks Ted for spotting this issue. I've changed the status of this from a bug to an improvement so as to not block the completion of QA testing. The file system does remain intact and the files are not corrupted, it would be nice however to remove the base folder. Thanks again, Adrian.
            Adrian Greeve made changes -
            Summary Non existing folder in download all files zip Download all as a zip creates a base directory '0'
            Issue Type Bug [ 1 ] Improvement [ 4 ]
            Description In My Private files, when downloading the zip file with the "Download all" link, a zip is succefully created.
            When opening this zip file there is a folder that shouldn't exist.

            Steps to reproduce:
            Navigate to My Private Files
            Create a folder
            Upload a file to this folder
            Click on "Save changes"
            Navigate to the main folder
            Click on "Download all"
            Open the zip file
            Navigate to the created folder
            There is another folder in the zip file that shouldn't exist.
            In My Private files, when downloading the zip file with the "Download all" link, a zip is successfully created.
            When opening this zip file there is a folder that shouldn't exist.

            Steps to reproduce:
            Navigate to My Private Files
            Create a folder
            Upload a file to this folder
            Click on "Save changes"
            Navigate to the main folder
            Click on "Download all"
            Open the zip file
            Navigate to the created folder
            There is another folder in the zip file that shouldn't exist.
            Adrian Greeve made changes -
            Summary Download all as a zip creates a base directory '0' Remove the base directory '0' when downloading all as a zip.
            Hide
            Michael de Raadt added a comment -

            Thanks for suggesting this, Ted.

            I've put that on the backlog so we can work in this later.

            Feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it.

            The test associated with this issue has been reset. It would be good if you could re-run the test.

            Show
            Michael de Raadt added a comment - Thanks for suggesting this, Ted. I've put that on the backlog so we can work in this later. Feel free to help us work on this issue. If you are able to provide a patch, please add a patch label so we will spot it. The test associated with this issue has been reset. It would be good if you could re-run the test.
            Michael de Raadt made changes -
            Fix Version/s STABLE backlog [ 10463 ]
            Labels mdlqa triaged
            Marina Glancy made changes -
            Link This issue has a non-specific relationship to MDL-32639 [ MDL-32639 ]
            Hide
            Marina Glancy added a comment -

            I'm linking it to MDL-32639, which is more complete list of problems when downloading a file

            Show
            Marina Glancy added a comment - I'm linking it to MDL-32639 , which is more complete list of problems when downloading a file
            Hide
            Vadim Dvorovenko added a comment -

            Take a look at MDL-32639 - i've added pathces there, and testing instructions

            Show
            Vadim Dvorovenko added a comment - Take a look at MDL-32639 - i've added pathces there, and testing instructions
            Vadim Dvorovenko made changes -
            Link This issue has a non-specific relationship to MDL-36122 [ MDL-36122 ]
            Frédéric Massart made changes -
            Link This issue has been marked as being related by MDL-29203 [ MDL-29203 ]
            Hide
            Frédéric Massart added a comment -

            Closing as resolved by MDL-32639.

            Show
            Frédéric Massart added a comment - Closing as resolved by MDL-32639 .
            Frédéric Massart made changes -
            Status Open [ 1 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Frédéric Massart made changes -
            Link This issue will be resolved by MDL-32639 [ MDL-32639 ]
            Frédéric Massart made changes -
            Link This issue has a non-specific relationship to MDL-32639 [ MDL-32639 ]

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: