Moodle
  1. Moodle
  2. MDL-33318

If you change the name of the admin folder, it will cause CRON to fail.

    Details

    • Rank:
      41168

      Description

      We are advised to change the name of the moodle/admin/ folder and there is a script in config.php to redirect calls to admin to the new name. However, in moodle/lib/cronlib.php, line 379 is hard coded with "require_once($CFG->dirroot . '/admin/registration/lib.php');"

      This causes the cron job to fail because it can't find cronlib.php.

      Thanks,
      Clarence Prudhoe

        Activity

        Hide
        Dan Marsden added a comment -

        thanks Clarence, fixes attached and submitted for peer review.

        Show
        Dan Marsden added a comment - thanks Clarence, fixes attached and submitted for peer review.
        Hide
        Dan Poltawski added a comment -

        Looks good Dan, pushing the integration button.

        Show
        Dan Poltawski added a comment - Looks good Dan, pushing the integration button.
        Hide
        Dan Marsden added a comment -

        pretty good turn around there! - within 30min of the bug report - it was picked up, patch written, peer reviewed and submitted for integration!

        Show
        Dan Marsden added a comment - pretty good turn around there! - within 30min of the bug report - it was picked up, patch written, peer reviewed and submitted for integration!
        Hide
        Aparup Banerjee added a comment - - edited

        This looks cool.
        although, can we either use everything inside the "" or all variables outside the '' and not mix styles up in the one line.
        personally i prefer - http://docs.moodle.org/dev/Coding_style#String_concatenation

        edit: err not sure why the example there is mixing up ""'s with ''s .. maybe its not mixing up styles really but it just read a little different with one $CFG outside and one inside.

        Show
        Aparup Banerjee added a comment - - edited This looks cool. although, can we either use everything inside the "" or all variables outside the '' and not mix styles up in the one line. personally i prefer - http://docs.moodle.org/dev/Coding_style#String_concatenation edit: err not sure why the example there is mixing up ""'s with ''s .. maybe its not mixing up styles really but it just read a little different with one $CFG outside and one inside.
        Hide
        Dan Marsden added a comment -

        fair call - feel free to change it yourself - I just saw this in the latest bug feed and was a very/quick easy one to provide a patch for.

        Show
        Dan Marsden added a comment - fair call - feel free to change it yourself - I just saw this in the latest bug feed and was a very/quick easy one to provide a patch for.
        Hide
        Aparup Banerjee added a comment -

        cool, thanks, done, integrated, good to test.

        Show
        Aparup Banerjee added a comment - cool, thanks, done, integrated, good to test.
        Hide
        Rossiani Wijaya added a comment -

        Hi guys,

        Cron is working fine with the patch. However, I the "site admin > registration" produces this error message:

        Coding error detected, it must be fixed by a programmer: Request for an unknown renderer class core_register_renderer
        Stack trace:
        line 219 of /lib/outputfactories.php: coding_exception thrown
        line 1073 of /lib/outputlib.php: call to standard_renderer_factory->get_renderer()
        line 648 of /lib/pagelib.php: call to theme_config->get_renderer()
        line 39 of /adminXX/registration/index.php: call to moodle_page->get_renderer()
        

        Also, "Purge all caches" link to /admin instead of /$CFG_admin.

        Show
        Rossiani Wijaya added a comment - Hi guys, Cron is working fine with the patch. However, I the "site admin > registration" produces this error message: Coding error detected, it must be fixed by a programmer: Request for an unknown renderer class core_register_renderer Stack trace: line 219 of /lib/outputfactories.php: coding_exception thrown line 1073 of /lib/outputlib.php: call to standard_renderer_factory->get_renderer() line 648 of /lib/pagelib.php: call to theme_config->get_renderer() line 39 of /adminXX/registration/index.php: call to moodle_page->get_renderer() Also, "Purge all caches" link to /admin instead of /$CFG_admin.
        Hide
        Rossiani Wijaya added a comment -

        I will let the integrator to decide on failing or passing this issue.

        Show
        Rossiani Wijaya added a comment - I will let the integrator to decide on failing or passing this issue.
        Hide
        Dan Poltawski added a comment -

        Passing this, although indeed this is another crazy broken thing with this /admin/ thing.

        I'm inclined to think we should get rid of this in the future, it can't be very well supported.

        Show
        Dan Poltawski added a comment - Passing this, although indeed this is another crazy broken thing with this /admin/ thing. I'm inclined to think we should get rid of this in the future, it can't be very well supported.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: