Moodle
  1. Moodle
  2. MDL-33319

No quick feedback option available in assignment 2.3 that has quick grading enabled

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:
    • Environment:
      Moodle QA site
    • Testing Instructions:
      Hide

      Create a new assignment selecting no for file and no for online submission options. Select yes for feedback options. Click save. Click the tick box for quick grading. See the option to input the grade, but not to type quick verbal comments.

      Show
      Create a new assignment selecting no for file and no for online submission options. Select yes for feedback options. Click save. Click the tick box for quick grading. See the option to input the grade, but not to type quick verbal comments.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
    • Rank:
      41169

      Description

      During test for MDLQA-1873, offline assignment feedback options, I found that it was only possible to give feedback if I clicked the edit option on each individual student. I had feedback set to yes and file upload feedback set to yes. Please see pics. One pic shows what I saw in the new assignment type, and one pic shows what I expected to see based on what is available in the old offline assignment type.

        Issue Links

          Activity

          Hide
          Lesli Smith added a comment -

          I just went back the site to test again just in case it was the fact that I had selected a file upload feedback option that turned off the quick grade comments option, but with or without the file feedback set to yes, I still get the same results.

          Show
          Lesli Smith added a comment - I just went back the site to test again just in case it was the fact that I had selected a file upload feedback option that turned off the quick grade comments option, but with or without the file feedback set to yes, I still get the same results.
          Hide
          Michael de Raadt added a comment -

          Thanks for testing this and following it through.

          Show
          Michael de Raadt added a comment - Thanks for testing this and following it through.
          Hide
          Lesli Smith added a comment -

          Hi, Michael. I was paying attention in your session. I swear I was. But could you tell me if when Damyon marks this "waiting for peer review" it means waiting for developer peer review or waiting for me to test it again (QA tester peer review on QA site)? I don't have anywhere to test code from github and wouldn't know how if I tried it, so it needs to be something on the QA site update cycle for me to try it. Right now, I'm assuming this stage of the peer review is where someone in dev is doing the review, but correct me if I'm wrong. Thanks!

          Show
          Lesli Smith added a comment - Hi, Michael. I was paying attention in your session. I swear I was. But could you tell me if when Damyon marks this "waiting for peer review" it means waiting for developer peer review or waiting for me to test it again (QA tester peer review on QA site)? I don't have anywhere to test code from github and wouldn't know how if I tried it, so it needs to be something on the QA site update cycle for me to try it. Right now, I'm assuming this stage of the peer review is where someone in dev is doing the review, but correct me if I'm wrong. Thanks!
          Hide
          Damyon Wiese added a comment -

          Hi Lesli,

          Waiting peer review means the code is done but it is waiting for another developer to take a look at it before the code it added to the integration repository. It only appears on the QA site once it is in integration.

          Regards, Damyon

          Show
          Damyon Wiese added a comment - Hi Lesli, Waiting peer review means the code is done but it is waiting for another developer to take a look at it before the code it added to the integration repository. It only appears on the QA site once it is in integration. Regards, Damyon
          Hide
          Lesli Smith added a comment -

          ok. Thanks for confirming. Just wanted to make sure you weren't waiting for me.

          Show
          Lesli Smith added a comment - ok. Thanks for confirming. Just wanted to make sure you weren't waiting for me.
          Hide
          Aparup Banerjee added a comment -

          Hi Damyon,
          This looks great to me, push this forward to integration now.

          ps: imo the bit fixing $_POST usage could likely have been a separate commit.

          Show
          Aparup Banerjee added a comment - Hi Damyon, This looks great to me, push this forward to integration now. ps: imo the bit fixing $_POST usage could likely have been a separate commit.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Lesli Smith added a comment -

          I was just about to comment (with screen shots) that it doesn't seem to be fixed yet when I re-read Dan's post. The code has been updated to the git repository, but not necessarily on the QA site, yet. Oops. My mistake. Please let me know when I'm supposed to test it. Thanks.

          Show
          Lesli Smith added a comment - I was just about to comment (with screen shots) that it doesn't seem to be fixed yet when I re-read Dan's post. The code has been updated to the git repository, but not necessarily on the QA site, yet. Oops. My mistake. Please let me know when I'm supposed to test it. Thanks.
          Hide
          Dan Poltawski added a comment -

          Thanks, i've integrated this now.

          Note I discovered some of the phpdocs were misleading, e.g.:
          @return mixed - A html string containing the html form elements required for quickgrading

          However this is a QA issue, so I have ignored that for here.

          Show
          Dan Poltawski added a comment - Thanks, i've integrated this now. Note I discovered some of the phpdocs were misleading, e.g.: @return mixed - A html string containing the html form elements required for quickgrading However this is a QA issue, so I have ignored that for here.
          Hide
          Dan Poltawski added a comment -

          Manually passing test as this is in QA testing.

          Show
          Dan Poltawski added a comment - Manually passing test as this is in QA testing.
          Hide
          Lesli Smith added a comment -

          Hi. Sorry. Still not seeing the ability to give quick feedback on an offline assignment in the new assignment type. I did double-check that I was taking into account time-zones, but let me know if I tested too early.

          Show
          Lesli Smith added a comment - Hi. Sorry. Still not seeing the ability to give quick feedback on an offline assignment in the new assignment type. I did double-check that I was taking into account time-zones, but let me know if I tested too early.
          Hide
          gavin henrick added a comment -

          I saw the comment in the quick grading however it is the 2nd last column and not beside the grade column which it probably should be.

          As it is now, a teacher would need to horizontally scroll every time to do grade then comment, scroll back grade scroll comment scroll grade.

          Show
          gavin henrick added a comment - I saw the comment in the quick grading however it is the 2nd last column and not beside the grade column which it probably should be. As it is now, a teacher would need to horizontally scroll every time to do grade then comment, scroll back grade scroll comment scroll grade.
          Hide
          Damyon Wiese added a comment -

          The new assign module does not know anything about the plugins it just lists the columns for all the submission plugins, followed by all the feedback plugins in the order they are defined in the admin settings (the feedback textbox is provided by the feedback comments plugin). The only change I can see here would be to list the feedback plugins before the submission plugins but I think in most cases it makes more sense to show the submission columns first.

          Regards, Damyon

          Show
          Damyon Wiese added a comment - The new assign module does not know anything about the plugins it just lists the columns for all the submission plugins, followed by all the feedback plugins in the order they are defined in the admin settings (the feedback textbox is provided by the feedback comments plugin). The only change I can see here would be to list the feedback plugins before the submission plugins but I think in most cases it makes more sense to show the submission columns first. Regards, Damyon
          Hide
          Lesli Smith added a comment -

          Maybe I didn't calculate the timezones correctly. In any case, it is there now. Thanks! See attached confirmation pic.

          Show
          Lesli Smith added a comment - Maybe I didn't calculate the timezones correctly. In any case, it is there now. Thanks! See attached confirmation pic.
          Hide
          Dan Poltawski added a comment -

          Hi Lesli, Thanks for the testing and confirmation!

          Show
          Dan Poltawski added a comment - Hi Lesli, Thanks for the testing and confirmation!
          Hide
          gavin henrick added a comment -

          Damyon, but this is a change from the existing assignment grading layout

          Does it make sense to have the grade and text comment for feedback with potentially lots of fields between them pushing it offscreen?

          Have you tested that with a teacher have to grade 20 items?

          Surely usability comes before technical logic here on ouput?

          Show
          gavin henrick added a comment - Damyon, but this is a change from the existing assignment grading layout Does it make sense to have the grade and text comment for feedback with potentially lots of fields between them pushing it offscreen? Have you tested that with a teacher have to grade 20 items? Surely usability comes before technical logic here on ouput?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.

          Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.

          Many thanks for your collaboration!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3. Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish. Many thanks for your collaboration! Ciao
          Hide
          Mary Cooch added a comment -

          I just wanted to reiterate Gavin's concern here about the position of the feedback comment area and the grade being separated -a lot of our teachers use this feature and I can see them getting frustrated by the new layout.

          Show
          Mary Cooch added a comment - I just wanted to reiterate Gavin's concern here about the position of the feedback comment area and the grade being separated -a lot of our teachers use this feature and I can see them getting frustrated by the new layout.
          Hide
          Dan Poltawski added a comment -

          Hi Mary/Gavin,

          Please can we address this in a new issue since this has been integrated and tested now.

          thanks,
          dan

          Show
          Dan Poltawski added a comment - Hi Mary/Gavin, Please can we address this in a new issue since this has been integrated and tested now. thanks, dan
          Hide
          Lesli Smith added a comment -

          I admit I didn't notice this because I was looking at the offline assignment that has no submissions.

          Gavin and Mary are right, though. I've attached a for-instance so that you can see what we mean. Once teachers start cranking out the complex types of assignments this new assignment type allows (and it is pretty awesome, so thank you!) they will have trouble tracking who did what as they lose the student name off to the left. I understand this is probably a separate issue to track, so I can open it IF there is any indication from you in dev that it is something you can and/or are willing to fix. I understand crunch time is upon us, but those of us bringing this to your attention know it will be a big deal to teachers and will likely hit the tracker after release of 2.3 anyway. In short, please advise.

          Show
          Lesli Smith added a comment - I admit I didn't notice this because I was looking at the offline assignment that has no submissions. Gavin and Mary are right, though. I've attached a for-instance so that you can see what we mean. Once teachers start cranking out the complex types of assignments this new assignment type allows (and it is pretty awesome, so thank you!) they will have trouble tracking who did what as they lose the student name off to the left. I understand this is probably a separate issue to track, so I can open it IF there is any indication from you in dev that it is something you can and/or are willing to fix. I understand crunch time is upon us, but those of us bringing this to your attention know it will be a big deal to teachers and will likely hit the tracker after release of 2.3 anyway. In short, please advise.
          Hide
          Dan Poltawski added a comment -

          Hi Lesli,

          You, putting this in another issue doesn't mean we will not address it. If its a critical issue then raising it us early is appreciated. I don't know if/how its possible to implement this, but I know for sure that we can't do it in this issue here - so it'd be great to have it raised and discused in a new issue (please post the link here).

          Show
          Dan Poltawski added a comment - Hi Lesli, You, putting this in another issue doesn't mean we will not address it. If its a critical issue then raising it us early is appreciated. I don't know if/how its possible to implement this, but I know for sure that we can't do it in this issue here - so it'd be great to have it raised and discused in a new issue (please post the link here).
          Hide
          Lesli Smith added a comment -

          Hi, Dan. Done. Submitted here: MDL-33706 I'm still learning how to link these, so if I linked them incorrectly, please let me know. Thanks!

          Show
          Lesli Smith added a comment - Hi, Dan. Done. Submitted here: MDL-33706 I'm still learning how to link these, so if I linked them incorrectly, please let me know. Thanks!
          Hide
          Dan Poltawski added a comment -

          Thanks! I have linked it using the 'more actions' -> 'link' menu, but i'm not sure everyone has the permission to do this.

          Show
          Dan Poltawski added a comment - Thanks! I have linked it using the 'more actions' -> 'link' menu, but i'm not sure everyone has the permission to do this.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: