Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32999 META: Files UI Stage 2 polishing in master
  3. MDL-33325

When in "edit" filemanager for standard folder activity, should not see "Set main file" button.

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide
      1. Add a folder resource to a course
      2. Add a few files to the resource
      3. Try editing any file.
      4. Make sure the file-picker pop-up doesn't contain the button "Set as main file" (in stables right click on the file and make sure ,there is no such option as 'set as main file')
      5. If it works as expected treat yourself with a cookie
      Show
      Add a folder resource to a course Add a few files to the resource Try editing any file. Make sure the file-picker pop-up doesn't contain the button "Set as main file" (in stables right click on the file and make sure ,there is no such option as 'set as main file') If it works as expected treat yourself with a cookie
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull Master Branch:
      MDL-33325-master

      Description

      I guess there is an options parameter for this page that just needs to be removed.

        Gliffy Diagrams

          Issue Links

            Activity

            dougiamas Martin Dougiamas created issue -
            dougiamas Martin Dougiamas made changes -
            Field Original Value New Value
            Fix Version/s MUST FIX FOR 2.3 [ 12158 ]
            dougiamas Martin Dougiamas made changes -
            Assignee Marina Glancy [ marina ] moodle.com [ moodle.com ]
            salvetore Michael de Raadt made changes -
            Labels patch triaged
            Assignee moodle.com [ moodle.com ] Ankit Agarwal [ ankit_frenz ]
            Affects Version/s 2.3 [ 10657 ]
            Affects Version/s MUST FIX FOR 2.3 [ 12158 ]
            ankit_frenz Ankit Agarwal made changes -
            Pull Master Diff URL https://github.com/ankitagarwal/moodle/compare/MDL-33325-master
            Pull Master Branch MDL-33325-master
            Peer reviewer rwijaya
            Testing Instructions # Add a folder resource to a course
            # Add a few files to the resource
            # Try editing any file.
            # Make sure the file-picker pop-up doesn't contain the button "Set as main file"
            # If it works as expected treat yourself with a cookie :)
            Pull from Repository git://github.com/ankitagarwal/moodle.git
            ankit_frenz Ankit Agarwal made changes -
            Testing Instructions # Add a folder resource to a course
            # Add a few files to the resource
            # Try editing any file.
            # Make sure the file-picker pop-up doesn't contain the button "Set as main file"
            # If it works as expected treat yourself with a cookie :)
            # Add a folder resource to a course
            # Add a few files to the resource
            # Try editing any file.
            # Make sure the file-picker pop-up doesn't contain the button "Set as main file" (in stables right click on the file and make sure ,there is no such option as 'set as main file')
            # If it works as expected treat yourself with a cookie :)
            Pull 2.2 Diff URL https://github.com/ankitagarwal/moodle/compare/MOODLE_22_STABLE...MDL-33325-m22
            Pull 2.1 Branch MDL-33325-m21
            Pull 2.2 Branch MDL-33325-m22
            Pull 2.1 Diff URL https://github.com/ankitagarwal/moodle/compare/MOODLE_21_STABLE...MDL-33325-m21
            ankit_frenz Ankit Agarwal made changes -
            Status Open [ 1 ] Waiting for peer review [ 10012 ]
            rwijaya Rossiani Wijaya made changes -
            Original Estimate 0 minutes [ 0 ]
            Remaining Estimate 0 minutes [ 0 ]
            Status Waiting for peer review [ 10012 ] Peer review in progress [ 10013 ]
            rwijaya Rossiani Wijaya made changes -
            Status Peer review in progress [ 10013 ] Development in progress [ 3 ]
            ankit_frenz Ankit Agarwal made changes -
            Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator samhemelryk
            Currently in integration Yes [ 10041 ]
            samhemelryk Sam Hemelryk made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.1.7 [ 12161 ]
            Fix Version/s 2.2.4 [ 12162 ]
            Fix Version/s MUST FIX FOR 2.3 [ 12158 ]
            samhemelryk Sam Hemelryk made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Tester samhemelryk
            samhemelryk Sam Hemelryk made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            poltawski Dan Poltawski made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Currently in integration Yes [ 10041 ]
            Integration date 01/Jun/12
            fred Frédéric Massart made changes -
            Link This issue is duplicated by MDL-29119 [ MDL-29119 ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/12