Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Files API
    • Labels:
      None
    • Testing Instructions:
      Hide

      1. Open form with filepicker form element (for example 'Edit user profile')
      2. Make sure you can not insert file by reference ("create alias/shortcut") when selecting from "Private files"

      Show
      1. Open form with filepicker form element (for example 'Edit user profile') 2. Make sure you can not insert file by reference ("create alias/shortcut") when selecting from "Private files"
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-33329-master
    • Rank:
      41180

      Description

      Filepicker form element should not allow inserting references

        Activity

        Hide
        Marina Glancy added a comment -

        also fixed a little mess with 'maxbytes' restriction

        Show
        Marina Glancy added a comment - also fixed a little mess with 'maxbytes' restriction
        Hide
        Dan Poltawski added a comment -

        Hi Marina,

        I have integrated this, with a small bit of apprehension around the $PAGE->course stuff.

        We know the context right? I think we should really be using this rather than hacking around with $PAGE->course. However, I assume for now that we don't have that here yet, so i've integrated it.

        Show
        Dan Poltawski added a comment - Hi Marina, I have integrated this, with a small bit of apprehension around the $PAGE->course stuff. We know the context right? I think we should really be using this rather than hacking around with $PAGE->course. However, I assume for now that we don't have that here yet, so i've integrated it.
        Hide
        Marina Glancy added a comment -

        form element filepicker unfortunately doesn't know otherwise which context it is in. $PAGE->course is also used in getHtml() method of the same class.

        Show
        Marina Glancy added a comment - form element filepicker unfortunately doesn't know otherwise which context it is in. $PAGE->course is also used in getHtml() method of the same class.
        Hide
        Ankit Agarwal added a comment -

        Works as expected.
        Passing
        Thanks

        Show
        Ankit Agarwal added a comment - Works as expected. Passing Thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: