Moodle
  1. Moodle
  2. MDL-33352

Regression: usage of textlib static interface in Moodle2.1

    Details

    • Testing Instructions:
      Hide

      Run the demo REST client with the default function (create_users). It should success without warning/errors (if the users don't already exist )

      Show
      Run the demo REST client with the default function (create_users). It should success without warning/errors (if the users don't already exist )
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Rank:
      41210

      Description

      user/lib.php has two usages of textlib::strtolower but 2.1 uses textlib_get_instance()->strtolower

        Issue Links

          Activity

          Hide
          Mark Nielsen added a comment -

          Linking issue that introduced this problem.

          Show
          Mark Nielsen added a comment - Linking issue that introduced this problem.
          Hide
          Jérôme Mouneyrac added a comment -

          Thanks Mark. Will fix it soon.

          Show
          Jérôme Mouneyrac added a comment - Thanks Mark. Will fix it soon.
          Hide
          Jérôme Mouneyrac added a comment -

          By passing peer-review as it pretty straightforward. I've tested. Thanks Mark.

          Show
          Jérôme Mouneyrac added a comment - By passing peer-review as it pretty straightforward. I've tested. Thanks Mark.
          Hide
          Dan Poltawski added a comment -

          Thanks Mark/Jerome, i've integrated this now.

          Show
          Dan Poltawski added a comment - Thanks Mark/Jerome, i've integrated this now.
          Hide
          Frédéric Massart added a comment -

          Test successful on 2.1

          Show
          Frédéric Massart added a comment - Test successful on 2.1
          Hide
          Dan Poltawski added a comment -

          Congratulations!

          Your work has made into the latest Moodle release!

          You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

          Show
          Dan Poltawski added a comment - Congratulations! Your work has made into the latest Moodle release! You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: