Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33367

move_section function can lead to data corruption

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide

      Test 1:

      1. run phpunit course/tests/courselib_test.php

      Test 2:

      1. Turn AJAX off for course
      2. Move course up and down and make sure you can do it.

      Test 3:

      1. Turn AJAX on for course
      2. Drag and move course up and down and make sure you can do it.
      Show
      Test 1: run phpunit course/tests/courselib_test.php Test 2: Turn AJAX off for course Move course up and down and make sure you can do it. Test 3: Turn AJAX on for course Drag and move course up and down and make sure you can do it.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-33367
    • Pull Master Diff URL:

      Description

      move_section function is not using transaction and can lead to data corruption.
      Also, it should use move_section_to, as it do similar work.

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33546 Current week not updating after section drag-and-drop

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-33379 Remove deprecated move_section in course/lib.php

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33347 Sections can't be moved when ajax is turned off

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              rajeshtaneja Rajesh Taneja
              Reporter:
              rajeshtaneja Rajesh Taneja
              Integrator:
              Sam Hemelryk Sam Hemelryk
              Tester:
              Michael de Raadt Michael de Raadt
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12