Is the move_section() function used any more? Should it be deprecated?

It can be deprecated in future, probably in 2.5 or so.

Added deprecated message for move_section and removed it's usage.

Brief look, seems good - albeit I don't understand the change in reorder_section.

Thanks for the review Sam,

reorder_section api was not working properly for sections moving up. We were adding 1 to make it work.

So either we can live with it, or modify it to work as expected. I didn't find any other use-case for move_section_to or reorder_section, so preferred to rectify it and updated the test case.

Submitting it for integration.

In the code it says the function will be removed in 2.4 (in the comment and deprecation message). This should be 2.5.

Thanks Michael,

It is now changed to 2.5.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Branch re-based.

This has been integrated now thanks Raj.

Test result: Success

I tested this in 2.3 on Firefox. I assume by turning AJAX on and off you meant the setting at the site level. I also assume by moving a course up and down you meant moving a section up and down. I tried this in three ways:

• AJAX off at site level
• JS disabled in browser
• AJAX and JS enabled

I found an issue with weekly section highlighting which I have reported and linked. I also noted that dates were not updating correctly in weekly format, but this error was intermittent and I could not reproduce it when I wanted to.

The PHPUnit test passed without any problems.

We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.

Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.

Many thanks for your collaboration!

Ciao