Moodle
  1. Moodle
  2. MDL-33374

Add a new user action button displays 'Update profile'

    Details

    • Testing Instructions:
      Hide
      1. goto Settings > Site administration > Users > Account > Add a new user
      2. make sure the button at the end of page reads "Create user"
      3. goto Settings > Site administration > Users > Account > browse list of user > select a user > edit profile
      4. make sure the button at the end of page reads "Update profile"
      Show
      goto Settings > Site administration > Users > Account > Add a new user make sure the button at the end of page reads "Create user" goto Settings > Site administration > Users > Account > browse list of user > select a user > edit profile make sure the button at the end of page reads "Update profile"
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-33374-master
    • Rank:
      41246

      Description

      When adding a new user through 'Settings > Site administration > Users > Account > Add a new user', the submit button displays 'Update profile'. It should display 'Create user'.

        Activity

        Hide
        Michael de Raadt added a comment -

        I suppose this is because we're using the same form for creating and updating a profile. It shouldn't be too hard to distinguish.

        Show
        Michael de Raadt added a comment - I suppose this is because we're using the same form for creating and updating a profile. It shouldn't be too hard to distinguish.
        Hide
        Ankit Agarwal added a comment -

        Added ui_change label
        Requesting a review.

        Show
        Ankit Agarwal added a comment - Added ui_change label Requesting a review.
        Hide
        Rossiani Wijaya added a comment -

        This looks good Ankit.
        +1 for integration.

        Show
        Rossiani Wijaya added a comment - This looks good Ankit. +1 for integration.
        Hide
        Ankit Agarwal added a comment -

        Thanks for the review Rosie.
        Sending for integration!

        Show
        Ankit Agarwal added a comment - Thanks for the review Rosie. Sending for integration!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Ankit Agarwal added a comment -

        Rebased.

        Thanks!

        Show
        Ankit Agarwal added a comment - Rebased. Thanks!
        Hide
        Sam Hemelryk added a comment -

        This has been integrated, thanks guys

        Show
        Sam Hemelryk added a comment - This has been integrated, thanks guys
        Hide
        Rajesh Taneja added a comment -

        Looks good,

        Thanks for fixing this, Ankit.

        Show
        Rajesh Taneja added a comment - Looks good, Thanks for fixing this, Ankit.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

        This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

        Thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: