Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33374

Add a new user action button displays 'Update profile'

    Details

    • Testing Instructions:
      Hide
      1. goto Settings > Site administration > Users > Account > Add a new user
      2. make sure the button at the end of page reads "Create user"
      3. goto Settings > Site administration > Users > Account > browse list of user > select a user > edit profile
      4. make sure the button at the end of page reads "Update profile"
      Show
      goto Settings > Site administration > Users > Account > Add a new user make sure the button at the end of page reads "Create user" goto Settings > Site administration > Users > Account > browse list of user > select a user > edit profile make sure the button at the end of page reads "Update profile"
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-33374-master

      Description

      When adding a new user through 'Settings > Site administration > Users > Account > Add a new user', the submit button displays 'Update profile'. It should display 'Create user'.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            I suppose this is because we're using the same form for creating and updating a profile. It shouldn't be too hard to distinguish.

            Show
            salvetore Michael de Raadt added a comment - I suppose this is because we're using the same form for creating and updating a profile. It shouldn't be too hard to distinguish.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Added ui_change label
            Requesting a review.

            Show
            ankit_frenz Ankit Agarwal added a comment - Added ui_change label Requesting a review.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            This looks good Ankit.
            +1 for integration.

            Show
            rwijaya Rossiani Wijaya added a comment - This looks good Ankit. +1 for integration.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Thanks for the review Rosie.
            Sending for integration!

            Show
            ankit_frenz Ankit Agarwal added a comment - Thanks for the review Rosie. Sending for integration!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Rebased.

            Thanks!

            Show
            ankit_frenz Ankit Agarwal added a comment - Rebased. Thanks!
            Hide
            samhemelryk Sam Hemelryk added a comment -

            This has been integrated, thanks guys

            Show
            samhemelryk Sam Hemelryk added a comment - This has been integrated, thanks guys
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Looks good,

            Thanks for fixing this, Ankit.

            Show
            rajeshtaneja Rajesh Taneja added a comment - Looks good, Thanks for fixing this, Ankit.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12