Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Filepicker
    • Labels:

      Description

      suggestions welcome

        Gliffy Diagrams

          Attachments

          1. archive-128.png
            archive-128.png
            11 kB
          2. Examples of how Ubuntu have done this.jpg
            Examples of how Ubuntu have done this.jpg
            90 kB
          3. FileTypes_256.png
            FileTypes_256.png
            816 kB
          4. mp4-128.png
            mp4-128.png
            15 kB
          5. quicktime-128.png
            quicktime-128.png
            12 kB
          6. text-128.png
            text-128.png
            9 kB

            Issue Links

              Activity

              Hide
              marina Marina Glancy added a comment -

              review the current icons either here: http://marina.moodle.local/master/testicons.php
              or by creating the file testicons.php on your server from here: https://gist.github.com/2817911

              Show
              marina Marina Glancy added a comment - review the current icons either here: http://marina.moodle.local/master/testicons.php or by creating the file testicons.php on your server from here: https://gist.github.com/2817911
              Hide
              marina Marina Glancy added a comment -

              linking to MDL-33144 because that issue had some comments regarding the icons design

              Show
              marina Marina Glancy added a comment - linking to MDL-33144 because that issue had some comments regarding the icons design
              Hide
              timb Tim Barker added a comment -

              Remove the text from the top lefthand corner of each of the icons because .xls files are not .xlsx files, .aac files are not .mp3 file etc.

              Show
              timb Tim Barker added a comment - Remove the text from the top lefthand corner of each of the icons because .xls files are not .xlsx files, .aac files are not .mp3 file etc.
              Hide
              timb Tim Barker added a comment -

              Added an example from my pc of how Ubuntu have done this, by being very generic.

              Show
              timb Tim Barker added a comment - Added an example from my pc of how Ubuntu have done this, by being very generic.
              Hide
              marina Marina Glancy added a comment -

              also I copy from another issue, that the following extensions are not 'registered' in moodle:

              rar (Should be zip icon)
              7z (Should be zip icon)
              bz2 (Should be zip icon)
              exe
              jar
              cab
              bin
              apk
              iso
              img
              cue
              bat

              Show
              marina Marina Glancy added a comment - also I copy from another issue, that the following extensions are not 'registered' in moodle: rar (Should be zip icon) 7z (Should be zip icon) bz2 (Should be zip icon) exe jar cab bin apk iso img cue bat
              Hide
              barbararamiro Barbara Ramiro added a comment - - edited

              Attached is the original file type icons (FileTypes_256.png)

              Show
              barbararamiro Barbara Ramiro added a comment - - edited Attached is the original file type icons (FileTypes_256.png)
              Hide
              marina Marina Glancy added a comment -

              I would also prefer to see all programming languages source codes (php, java, cpp, etc.) in separate icon group

              Show
              marina Marina Glancy added a comment - I would also prefer to see all programming languages source codes (php, java, cpp, etc.) in separate icon group
              Hide
              dougiamas Martin Dougiamas added a comment -

              +1 on the programming files.

              Here is a great reference list: http://www.fileinfo.com/filetypes/common

              Show
              dougiamas Martin Dougiamas added a comment - +1 on the programming files. Here is a great reference list: http://www.fileinfo.com/filetypes/common
              Hide
              barbararamiro Barbara Ramiro added a comment - - edited

              Marina, here are the icons for source codes and others. Did i miss any? Do you want to add anything else?

              Show
              barbararamiro Barbara Ramiro added a comment - - edited Marina, here are the icons for source codes and others. Did i miss any? Do you want to add anything else?
              Hide
              dougiamas Martin Dougiamas added a comment -

              I actually thought this had landed ages ago!

              Show
              dougiamas Martin Dougiamas added a comment - I actually thought this had landed ages ago!
              Hide
              poltawski Dan Poltawski added a comment - - edited
              {removed}
              Show
              poltawski Dan Poltawski added a comment - - edited {removed}
              Hide
              poltawski Dan Poltawski added a comment -

              This is too much for me to fix. Please could you prepare a branch based on currnt integration.

              Show
              poltawski Dan Poltawski added a comment - This is too much for me to fix. Please could you prepare a branch based on currnt integration.
              Hide
              poltawski Dan Poltawski added a comment -

              Finally sorted this out

              (in terminal window, to Barbaras dismay)

              Show
              poltawski Dan Poltawski added a comment - Finally sorted this out (in terminal window, to Barbaras dismay)
              Hide
              poltawski Dan Poltawski added a comment -

              Assinging to Martin for testing.

              Show
              poltawski Dan Poltawski added a comment - Assinging to Martin for testing.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment - - edited

              Uhm, I've tried a bunch of them (mbz, rar, png, gig, txt...), both in the picker and in course page (file resource).

              The only annoyance I've found is that .zip are using "archive" instead of own "zip" icon. And also, that folder resources don't seem to show any icon and I think it would be sweet to show them there too.

              So I'm going to:

              1) add commit fixing the "zip" one. (nothing to do, I understood the patch wrongly)
              2) Keep this open in case you want to complete testing of all them.
              3) Release rc1 with this with 2) pending to complete.

              Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - - edited Uhm, I've tried a bunch of them (mbz, rar, png, gig, txt...), both in the picker and in course page (file resource). The only annoyance I've found is that .zip are using "archive" instead of own "zip" icon. And also, that folder resources don't seem to show any icon and I think it would be sweet to show them there too. So I'm going to: 1) add commit fixing the "zip" one. (nothing to do, I understood the patch wrongly) 2) Keep this open in case you want to complete testing of all them. 3) Release rc1 with this with 2) pending to complete. Ciao
              Hide
              dougiamas Martin Dougiamas added a comment -

              Agreed on the icons in folders. This a big hole in my opinion. MDL-33746

              Show
              dougiamas Martin Dougiamas added a comment - Agreed on the icons in folders. This a big hole in my opinion. MDL-33746
              Hide
              dougiamas Martin Dougiamas added a comment -

              Looks OK to me.

              I could carp about this or that little icon thing for ages but there's nothing blocking this patch (which improves a lot) and I would just work further on these holistically in 2.3.

              Show
              dougiamas Martin Dougiamas added a comment - Looks OK to me. I could carp about this or that little icon thing for ages but there's nothing blocking this patch (which improves a lot) and I would just work further on these holistically in 2.3.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

              Many, many thanks for your hard work!

              Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao
              Hide
              marycooch Mary Cooch added a comment -

              I think new and beautiful icons are documented in many areas of 2.3 docs so I am removing the docs_required label

              Show
              marycooch Mary Cooch added a comment - I think new and beautiful icons are documented in many areas of 2.3 docs so I am removing the docs_required label

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    25/Jun/12