Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Filepicker
    • Labels:
    • Rank:
      41253

      Description

      suggestions welcome

      1. archive-128.png
        11 kB
      2. Examples of how Ubuntu have done this.jpg
        90 kB
      3. FileTypes_256.png
        816 kB
      4. mp4-128.png
        15 kB
      5. quicktime-128.png
        12 kB
      6. text-128.png
        9 kB

        Issue Links

          Activity

          Hide
          Marina Glancy added a comment -

          review the current icons either here: http://marina.moodle.local/master/testicons.php
          or by creating the file testicons.php on your server from here: https://gist.github.com/2817911

          Show
          Marina Glancy added a comment - review the current icons either here: http://marina.moodle.local/master/testicons.php or by creating the file testicons.php on your server from here: https://gist.github.com/2817911
          Hide
          Marina Glancy added a comment -

          linking to MDL-33144 because that issue had some comments regarding the icons design

          Show
          Marina Glancy added a comment - linking to MDL-33144 because that issue had some comments regarding the icons design
          Hide
          Tim Barker added a comment -

          Remove the text from the top lefthand corner of each of the icons because .xls files are not .xlsx files, .aac files are not .mp3 file etc.

          Show
          Tim Barker added a comment - Remove the text from the top lefthand corner of each of the icons because .xls files are not .xlsx files, .aac files are not .mp3 file etc.
          Hide
          Tim Barker added a comment -

          Added an example from my pc of how Ubuntu have done this, by being very generic.

          Show
          Tim Barker added a comment - Added an example from my pc of how Ubuntu have done this, by being very generic.
          Hide
          Marina Glancy added a comment -

          also I copy from another issue, that the following extensions are not 'registered' in moodle:

          rar (Should be zip icon)
          7z (Should be zip icon)
          bz2 (Should be zip icon)
          exe
          jar
          cab
          bin
          apk
          iso
          img
          cue
          bat

          Show
          Marina Glancy added a comment - also I copy from another issue, that the following extensions are not 'registered' in moodle: rar (Should be zip icon) 7z (Should be zip icon) bz2 (Should be zip icon) exe jar cab bin apk iso img cue bat
          Hide
          Barbara Ramiro added a comment - - edited

          Attached is the original file type icons (FileTypes_256.png)

          Show
          Barbara Ramiro added a comment - - edited Attached is the original file type icons (FileTypes_256.png)
          Hide
          Marina Glancy added a comment -

          I would also prefer to see all programming languages source codes (php, java, cpp, etc.) in separate icon group

          Show
          Marina Glancy added a comment - I would also prefer to see all programming languages source codes (php, java, cpp, etc.) in separate icon group
          Hide
          Martin Dougiamas added a comment -

          +1 on the programming files.

          Here is a great reference list: http://www.fileinfo.com/filetypes/common

          Show
          Martin Dougiamas added a comment - +1 on the programming files. Here is a great reference list: http://www.fileinfo.com/filetypes/common
          Hide
          Barbara Ramiro added a comment - - edited

          Marina, here are the icons for source codes and others. Did i miss any? Do you want to add anything else?

          Show
          Barbara Ramiro added a comment - - edited Marina, here are the icons for source codes and others. Did i miss any? Do you want to add anything else?
          Hide
          Martin Dougiamas added a comment -

          I actually thought this had landed ages ago!

          Show
          Martin Dougiamas added a comment - I actually thought this had landed ages ago!
          Hide
          Dan Poltawski added a comment - - edited
          {removed}
          Show
          Dan Poltawski added a comment - - edited {removed}
          Hide
          Dan Poltawski added a comment -

          This is too much for me to fix. Please could you prepare a branch based on currnt integration.

          Show
          Dan Poltawski added a comment - This is too much for me to fix. Please could you prepare a branch based on currnt integration.
          Hide
          Dan Poltawski added a comment -

          Finally sorted this out

          (in terminal window, to Barbaras dismay)

          Show
          Dan Poltawski added a comment - Finally sorted this out (in terminal window, to Barbaras dismay)
          Hide
          Dan Poltawski added a comment -

          Assinging to Martin for testing.

          Show
          Dan Poltawski added a comment - Assinging to Martin for testing.
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Uhm, I've tried a bunch of them (mbz, rar, png, gig, txt...), both in the picker and in course page (file resource).

          The only annoyance I've found is that .zip are using "archive" instead of own "zip" icon. And also, that folder resources don't seem to show any icon and I think it would be sweet to show them there too.

          So I'm going to:

          1) add commit fixing the "zip" one. (nothing to do, I understood the patch wrongly)
          2) Keep this open in case you want to complete testing of all them.
          3) Release rc1 with this with 2) pending to complete.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Uhm, I've tried a bunch of them (mbz, rar, png, gig, txt...), both in the picker and in course page (file resource). The only annoyance I've found is that .zip are using "archive" instead of own "zip" icon. And also, that folder resources don't seem to show any icon and I think it would be sweet to show them there too. So I'm going to: 1) add commit fixing the "zip" one. (nothing to do, I understood the patch wrongly) 2) Keep this open in case you want to complete testing of all them. 3) Release rc1 with this with 2) pending to complete. Ciao
          Hide
          Martin Dougiamas added a comment -

          Agreed on the icons in folders. This a big hole in my opinion. MDL-33746

          Show
          Martin Dougiamas added a comment - Agreed on the icons in folders. This a big hole in my opinion. MDL-33746
          Hide
          Martin Dougiamas added a comment -

          Looks OK to me.

          I could carp about this or that little icon thing for ages but there's nothing blocking this patch (which improves a lot) and I would just work further on these holistically in 2.3.

          Show
          Martin Dougiamas added a comment - Looks OK to me. I could carp about this or that little icon thing for ages but there's nothing blocking this patch (which improves a lot) and I would just work further on these holistically in 2.3.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

          Many, many thanks for your hard work!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao
          Hide
          Mary Cooch added a comment -

          I think new and beautiful icons are documented in many areas of 2.3 docs so I am removing the docs_required label

          Show
          Mary Cooch added a comment - I think new and beautiful icons are documented in many areas of 2.3 docs so I am removing the docs_required label

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: