Moodle
  1. Moodle
  2. MDL-33397

Private file area should have a cancel button when accessed from navigation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3
    • Fix Version/s: 2.2.4
    • Component/s: Filepicker
    • Labels:
    • Testing Instructions:
      Hide

      1. Navigate to Navigation > My profile > My private files. Click the Manage my private files button.
      2. Click 'Add' and verify that the file picker is launched.
      3. Select 'Upload a file' and select a file.
      4. Select Upload this file then verify that the file appears in the File Manager and that the details are correct.
      5. Make sure there is a cancel button and clicking on it reverts the changes and brings you back to the same page.

      6. Go to the home page, click on the button 'Manage my private files' in the 'My private files' block.
      7. Select 'Upload a file' and select a file.
      8. Select Upload this file then verify that the file appears in the File Manager and that the details are correct.
      9. Make sure there is a cancel button and clicking on it reverts the changes and brings you back to the home page.

      Show
      1. Navigate to Navigation > My profile > My private files. Click the Manage my private files button. 2. Click 'Add' and verify that the file picker is launched. 3. Select 'Upload a file' and select a file. 4. Select Upload this file then verify that the file appears in the File Manager and that the details are correct. 5. Make sure there is a cancel button and clicking on it reverts the changes and brings you back to the same page. 6. Go to the home page, click on the button 'Manage my private files' in the 'My private files' block. 7. Select 'Upload a file' and select a file. 8. Select Upload this file then verify that the file appears in the File Manager and that the details are correct. 9. Make sure there is a cancel button and clicking on it reverts the changes and brings you back to the home page.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33397-master
    • Rank:
      41271

      Description

      Private file area should have a cancel button when accessed from navigation

      Replication steps:-
      Test Steps:
      1. Navigate to Navigation > My profile > My private files. Click the Manage my private files button.
      2. Click 'Add' and verify that the file picker is launched.
      3. Select 'Upload a file' and select a file.
      4. Select Upload this file then verify that the file appears in the File Manager and that the details are correct.

      Expected result:-
      There is an option to cancel or save changes

      Actual result:-
      There is no option to cancel the changes

        Issue Links

          Activity

          Hide
          Frédéric Massart added a comment -

          Note to reviewer: I removed the support for $cancelbutton because I had added this for this specific case and is not used anymore.

          Show
          Frédéric Massart added a comment - Note to reviewer: I removed the support for $cancelbutton because I had added this for this specific case and is not used anymore.
          Hide
          Aparup Banerjee added a comment -

          Hi Fred,
          code wise it looks ok but i don't think its a good idea to drop any sort of functionality in a stable branch.

          Show
          Aparup Banerjee added a comment - Hi Fred, code wise it looks ok but i don't think its a good idea to drop any sort of functionality in a stable branch.
          Hide
          Frédéric Massart added a comment -

          Discussed with Apu, we thought we would ask the integrators opinion on the 'stable' patch. See MDL-32981 to see where the cancel button vanished.

          Show
          Frédéric Massart added a comment - Discussed with Apu, we thought we would ask the integrators opinion on the 'stable' patch. See MDL-32981 to see where the cancel button vanished.
          Hide
          Dan Poltawski added a comment -

          Yep, I thought integrating that original change in the stable branch was questionable, I only did it because MD suggested it

          So I think its OK to reverse this change and i'm going to integrate to both branches.

          Show
          Dan Poltawski added a comment - Yep, I thought integrating that original change in the stable branch was questionable, I only did it because MD suggested it So I think its OK to reverse this change and i'm going to integrate to both branches.
          Hide
          Dan Poltawski added a comment -

          Thanks Fred, integrated now.

          Show
          Dan Poltawski added a comment - Thanks Fred, integrated now.
          Hide
          Aparup Banerjee added a comment -

          this works \o/ . passing.

          Show
          Aparup Banerjee added a comment - this works \o/ . passing.
          Hide
          Dan Poltawski added a comment -

          Congratulations!

          Your work has made into the latest Moodle release!

          You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

          Show
          Dan Poltawski added a comment - Congratulations! Your work has made into the latest Moodle release! You are only authorised to celebrate after testing 15 Moodle 2.3 QA tests, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: