Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Filepicker
    • Labels:
      None
    • Rank:
      41294

      Description

      When the file is a reference or is a source of reference we show the icon in filemanager.
      We should show the same in filepicker.

      Show reference icon - always (repositories: coursefiles, local, user, recent?)
      Show source icon in repositories: coursefiles, user.
      Do NOT show source icon in server files (repository_local) in coursefiles subfolder (because we don't know whether it is current course or not)

      Also show reference source and shortcut/aliases in filepicker 'select file' window the same way they are shown in filemanager

        Activity

        Hide
        Marina Glancy added a comment -

        also show if original missing for references (if known), see MDL-33550

        Show
        Marina Glancy added a comment - also show if original missing for references (if known), see MDL-33550
        Hide
        Marina Glancy added a comment -

        I agree that we should display link icon
        though it is doubtful if we need to display "source" icon. To get this information we need to perform a query for each file counting references to it. It could be rather time consuming (especially for server files). Maybe this is not needed in filepicker?

        Show
        Marina Glancy added a comment - I agree that we should display link icon though it is doubtful if we need to display "source" icon. To get this information we need to perform a query for each file counting references to it. It could be rather time consuming (especially for server files). Maybe this is not needed in filepicker?
        Hide
        Martin Dougiamas added a comment -

        Agreed, the link icon is the one that counts because files can't be deleted in the filepicker.

        Show
        Martin Dougiamas added a comment - Agreed, the link icon is the one that counts because files can't be deleted in the filepicker.
        Hide
        Dan Poltawski added a comment -

        Marina, this doesn't seem to be working in my testing.

        Show
        Dan Poltawski added a comment - Marina, this doesn't seem to be working in my testing.
        Hide
        Dan Poltawski added a comment -

        Screenshot showing reference in filepicker and refernce in filemanager.

        Show
        Dan Poltawski added a comment - Screenshot showing reference in filepicker and refernce in filemanager.
        Hide
        CiBoT added a comment -

        Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

        Show
        CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
        Hide
        Marina Glancy added a comment -

        fixed variable name causing non-displaying of link in repository_local

        Show
        Marina Glancy added a comment - fixed variable name causing non-displaying of link in repository_local
        Hide
        Dan Poltawski added a comment -

        Integrated, ready for testing.

        Show
        Dan Poltawski added a comment - Integrated, ready for testing.
        Hide
        Ankit Agarwal added a comment -

        I cannot see the link icons.
        see attached pic.
        Failing this sorry!

        Show
        Ankit Agarwal added a comment - I cannot see the link icons. see attached pic. Failing this sorry!
        Hide
        Ankit Agarwal added a comment -

        This is working as expected.
        Must have been some issue with my catch or something.
        Passing
        thanks

        Show
        Ankit Agarwal added a comment - This is working as expected. Must have been some issue with my catch or something. Passing thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

        Many, many thanks for your hard work!

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: