Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.2.3
-
Component/s: Activity completion, Filters, Language
-
Labels:
-
Affected Branches:MOODLE_22_STABLE
-
Fixed Branches:MOODLE_22_STABLE, MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-33426-master -
Pull Master Diff URL:
Description
When using the multilang filter (http://docs.moodle.org/en/Multi-language_content_filter) with activity completion, the span tags used in activity names are present in the tip that appears when hovering over an activity completion checkbox.
Replication steps:
- Log in as admin
- Navigate to Site admin > Plugins > Filters > Manage filters
- Set the Multi-language content filter to On and allow it to apply to "Content and headings"
- Navigate to Site admin > Advanced features
- Check "Enable completion tracking" (enablecompletion)
- Navigate to a course
- Edit the course's settings and in the Student progress section, set Completion tracking to "Enabled,..."
- Save settings
- Turn editing on
- Create an activity such as a quiz.
- Add the following as the activity name: <span lang="en" class="multilang">This is a test</span><span lang="de" class="multilang">Dies ist ein Test</span>
- In the Activity completion settings section, set the Completion tracking option to "Students can manually mark..."
- Save the activity and return to the course
- Turn editing off
- Hover over the completion checkbox for the newly created quiz
Expected result: The tip shows "Mark as complete:" followed by the filtered name
Actual result: The name supplied with tags and both translations appears
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Here's a fix for review.
In addition to fixing the problem on the course page, I realised the same thing would happen in the activity completion report, so I fixed that too.
Looks good. I'm guessing this bug almost certainly exists in both 2.2 and 2.1. I'm fairly certain that context_module::instance($mod->id) doesnt exist in 2.2 or 2.1 so unfortunately you wont be able to do a straight cherry-pick.
context_*::instance is in 2.2, just not 2.1. As this is only a minor bug I suggest leaving it broken in 2.1. Will submit for integration on 2.2 and master shortly.
also - thanks for review 
Uhm.. I know it's an small inconsistency... but.. who decides if one activity title is processed with the multilang filter, the activity filters or the course filters?
I think it's the former, but in the report you're using the later...
Holding this a bit...
OK, it didn't already have it and looks like I was too lazy to make it get the right context in report/progress I'll do an updated version shortly.
I added a line to get the modcontext and rebased both branches on current master (should be == 23) and 22. Also retested (the master version), still seems to work.
How about that?
Perfect, thanks. Proceeding...
Integrated, thanks! (22, 23 and master).
Test passed on 2.2, 2.3, master! Cheers!
Congratulations your code is upstream - gold star for you!
This issue + 79 others made it in in time for the minor releases.
Thank you everyone involved for your exuberant efforts.
Probably a bit of a fringe case.