Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32999 META: Files UI Stage 2 polishing in master
  3. MDL-33445

Inserting a file by reference bypasses the file size limit check

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Not a bug
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Filepicker, Repositories
    • Labels:
    • Testing Instructions:
      Hide

      1. Login as teacher/admin
      2. Add some big file to your private files or to course legacy files and some small file
      3. Edit some course settings and set the file size limit less than size of big file in #2 (but more than small file size)
      4. Create file/folder resource
      5. Try inserting files from your private files as shortcut/alias, make sure you can insert only small file.

      Show
      1. Login as teacher/admin 2. Add some big file to your private files or to course legacy files and some small file 3. Edit some course settings and set the file size limit less than size of big file in #2 (but more than small file size) 4. Create file/folder resource 5. Try inserting files from your private files as shortcut/alias, make sure you can insert only small file.
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      When inserting file as an alias/shortcut the repository/repository_ajax.php does not check if it exceeds $maxbytes

      keywords: maxbytes file_is_draft_area_limit_reached file_get_draft_area_info maxareabytes alias shortcut aliases shortcuts

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              dougiamas Martin Dougiamas added a comment -

              Yes, this is OK. Files that are references should not contribute towards quota for that filearea.

              Show
              dougiamas Martin Dougiamas added a comment - Yes, this is OK. Files that are references should not contribute towards quota for that filearea.
              Hide
              marina Marina Glancy added a comment -

              I have to link to this issue often. This is a fake comment with some keywords people use to search for it:
              maxbytes file_is_draft_area_limit_reached file_get_draft_area_info maxareabytes alias shortcut aliases shortcuts

              Show
              marina Marina Glancy added a comment - I have to link to this issue often. This is a fake comment with some keywords people use to search for it: maxbytes file_is_draft_area_limit_reached file_get_draft_area_info maxareabytes alias shortcut aliases shortcuts

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: