how mdl_grade_items (course=11262) looked before the upgrade of assignments

how mdl_grade_items (course=11262) looked after the upgrade of assignments

Note the duplicated assignments

Hopefully no one minds but I'm raising this to blocker. This effectively bricks a course, since the assignment(s) in question and the gradebook is no longer accessible. Here's a stack trace from 20120612:

Debug info:
Error code: morethanonerecordinfetch
Stack trace:
line 467 of /lib/setuplib.php: moodle_exception thrown
line 163 of /lib/grade/grade_object.php: call to print_error()
line 326 of /lib/grade/grade_item.php: call to grade_object::fetch_helper()
line 979 of /lib/grade/grade_item.php: call to grade_item::fetch()
line 1010 of /lib/gradelib.php: call to grade_item::fetch_course_item()
line 106 of /grade/report/grader/index.php: call to grade_regrade_final_grades()

Thanks - I agree this is a blocker - I'll look at it right now.

Do not create the grade item on upgrade because we already reused the grade item from the old assignment.

(Removed testing instructions from description)

Hi Michael,

The patch here fixes the issue for me - I'm not sure when this regression slipped in. Any re-testing that you could do on this issue would be greatly appreciated (particularly around overwriting the category grade items). The fix is to remove one line from /mod/assign/upgradelib.php (see the pull master diff url above). Also - how long did it take for you to upgrade 24,000 assignments?

Regards, Damyon

Hi Damyon,
This looks great.
can you update the testing instructions please? so that it checks if it is fixed, instead of trying to reproduce it.
Feel free to submit this for integration.
Thanks

Testing instructions updated.

Thanks Ankit, sending for integration.

Thanks Damyon. I'm offline for a couple of days, but will try to rerun a large test soon (I'll time it, and let you know how long it takes).

Thanks, i've integrated this now

And the test passes! Thanks guys!

Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

Ciao

Time to convert 24,500 assignment was about 4 hours.

I'm no longer getting the duplication of grade items, BUT on my freshly upgraded 1.9 site, the grade_item records where itemtype='category' are getting their itemmodule values changed from NULL to 'assign'. In fact the only grade_item records that are not getting updated to 'assign' are the manual grade item records (itemtype='manual'). However, when I try to create a simple test in the upgraded site (new course, new gradebook setup with categories and sub-categories), I cannot replicate the bug. That is, the assignment upgrade routine only touches the assignment records.

I'll let you know if I can work anything out.

Thanks,
Michael

Example of category records in grade_items getting overwritten by the new assignment module during upgrade.