Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33464

Assignment Upgrade Helper causes duplication in the gradebook

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Steps to reproduce:

      1. Ensure both assignment versions are enabled and visible via site admin
      2. Create brand new empty course with some students
      3. Create 2 x v2.2 assignments of any type
      4. I added at least one grade for each assignment
      5. Run the Assignment Upgrade Helper. The two assignments you just created should be listed. Click 'Upgrade all'.
      6. Go to the course and verify that the assignments have been upgraded.
      7. Go to the course gradebook and see how many assignments appear for the course.

      Expected result.

      1. There should be 2 assignments in the gradebook
        Actual result
      2. There are 4 assignments in the gradebook
      Show
      Steps to reproduce: Ensure both assignment versions are enabled and visible via site admin Create brand new empty course with some students Create 2 x v2.2 assignments of any type I added at least one grade for each assignment Run the Assignment Upgrade Helper. The two assignments you just created should be listed. Click 'Upgrade all'. Go to the course and verify that the assignments have been upgraded. Go to the course gradebook and see how many assignments appear for the course. Expected result. There should be 2 assignments in the gradebook Actual result There are 4 assignments in the gradebook
    • Workaround:
      Hide

      If anyone needs some SQL to fix their install it would be possible (delete the second grade item from the database).

      Show
      If anyone needs some SQL to fix their install it would be possible (delete the second grade item from the database).
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      Running the 'Assignment Upgrade Helper' to convert v2.2 assignments to v2.3 assignments causes the assignments to duplicate in the gradebook.

      The above is a simple test, but it did massive damage to a test upgrade of 24,000 assignments, including overstamping 'category' records with itemmodule='assign'.

        Attachments

          Issue Links

          Discovered while testing

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33793 Assignment upgrade tool overwrites unrelated records in gradebook

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              damyon Damyon Wiese
              Reporter:
              mcwoods Michael Woods
              Peer reviewer:
              Ankit Agarwal
              Integrator:
              Dan Poltawski
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              19 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12