Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33468

CSS optimiser breaking theme's when enabled

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin
      2. Make sure you have the CSS optimiser enabled
      3. Disable theme designer mode if you have it on
      4. Enable allowthemechangeonurl so that you can easily switch themes
      5. Add a custom menu if you don't already have one
      6. Using your current theme browse around the site and check out at least the following things. For each you are looking to make sure things appear OK, ideally there should be no differences between the theme with the optimiser on and off (you could use a second site+browser to check things with the optimiser disabled).
        • Front page
        • Course page with editing on
        • Play with the custom menu
        • Quickly check the filemanager/filepicker
        • Dock a block and check it pops out OK.
      7. Repeat this trying the different themes we have in Moodle.

      (Please note this doesn't work properly with the mymobile theme yet, see linked MDL-33596)

      Show
      Log in as an admin Make sure you have the CSS optimiser enabled Disable theme designer mode if you have it on Enable allowthemechangeonurl so that you can easily switch themes Add a custom menu if you don't already have one Using your current theme browse around the site and check out at least the following things. For each you are looking to make sure things appear OK, ideally there should be no differences between the theme with the optimiser on and off (you could use a second site+browser to check things with the optimiser disabled). Front page Course page with editing on Play with the custom menu Quickly check the filemanager/filepicker Dock a block and check it pops out OK. Repeat this trying the different themes we have in Moodle. (Please note this doesn't work properly with the mymobile theme yet, see linked MDL-33596 )
    • Workaround:
      Hide

      Disable the CSS optimiser.

      Show
      Disable the CSS optimiser.
    • Difficulty:
      Moderate
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-33468-m23

      Description

      Presently if you enable the CSS optimiser in master you will find it is breaking any theme you use.
      I've tracked the problem back to the introduction of the keyframes rules used to control an animation in the filepicker/filemanager.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12