Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33475

Grading action menu in an assignment with marking guide does not show up

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an instance of mod_assign in a course
      2. In the settings for the assignment set the grading method to one of the advanced grading methods e.g. "Marking guide"
      3. Create an advanced grading form and make it ready for use in the assignment
      4. Go to the assignment marking page (View/grade all submissions)
      5. Verify that the drop down menu for each submission (In the Edit column) is functioning and there are no reported javascript errors for the page.
      Show
      Create an instance of mod_assign in a course In the settings for the assignment set the grading method to one of the advanced grading methods e.g. "Marking guide" Create an advanced grading form and make it ready for use in the assignment Go to the assignment marking page (View/grade all submissions) Verify that the drop down menu for each submission (In the Edit column) is functioning and there are no reported javascript errors for the page.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      Using Firefox, Chrome or even Opera, a javascript error occurs on the grading page.

      To replicate, follow MDLQA-2395 test steps. The step 3 is the one causing this issue because the menu is not showing up on hover.

      Uncaught exception: TypeError: Cannot convert 'quickgradingelement' to object
       
      Error thrown at line 1147, column 12 in <anonymous function: error>(msg, e, src) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          throw (e || new Error(msg));
      called from line 838, column 16 in <anonymous function: _notify>(callback, response, args) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          this.error('use callback error', e, args);
      called from line 971, column 24 in <anonymous function: _use>(fromLoader) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          Y._notify(callback, response, args);
      called via Function.prototype.call() from line 7411, column 12 in <anonymous function: _finish>(msg, success) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          onEnd.call(this.context, {
      called from line 7456, column 8 in <anonymous function: _onSuccess>() in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          self._finish(msg, success);
      called via Function.prototype.call() from line 7653, column 20 in <anonymous function: _insert>(d) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          fn.call(self, d);
      called via Function.prototype.call() from line 7715, column 20 in <anonymous function: onSuccess>(d) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          complete.call(self, d);
      called via Function.prototype.call() from line 4624, column 12 in <anonymous function: _finish>() in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          options.onSuccess.call(thisObj, data);
      called from line 4806, column 12 in <anonymous function: _next>() in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          this._finish();
      called from line 4913, column 8 in <anonymous function: _progress>(err, req) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          this._next();
       
      Error initially occurred at line 143, column 8 in <anonymous function: M.mod_assign.init_grading_options>(Y) in http://fred.moodle.local/testing_master/mod/assign/module.js:
          quickgradingelement.on('change', function(e) {
      called from line 836, column 16 in <anonymous function: _notify>(callback, response, args) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          callback(this, response);
      called from line 817, column 16 in <anonymous function: use>(Y, response) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          Y._notify(callback, response, args);
      called from line 836, column 16 in <anonymous function: _notify>(callback, response, args) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          callback(this, response);
      called from line 971, column 24 in <anonymous function: _use>(fromLoader) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          Y._notify(callback, response, args);
      called from line 1057, column 16 in <anonymous function: _use>(args, callback) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          handleLoader();
      called from line 816, column 12 in <anonymous function: use>() in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          Y._use(args, function(Y, response) {
      called from line 132, column 4 in <anonymous function: M.mod_assign.init_grading_options>(Y) in http://fred.moodle.local/testing_master/mod/assign/module.js:
          Y.use('node', function(Y) {
      called from line 19, column 54 in <anonymous function>(Y) in http://fred.moodle.local/testing_master/mod/assign/view.php?action=grading&id=1079&tshow=edit:
          M.mod_assign.init_grading_options(Y);
      called from line 836, column 16 in <anonymous function: _notify>(callback, response, args) in http://fred.moodle.local/testing_master/lib/yui/3.5.1/build/yui/yui.js:
          callback(this, response);

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            danmarsden Dan Marsden added a comment -

            assigning this back to moodle.com - this is also a problem when the rubrics grading method is selected - so either a problem with mod/assign or needs to be fixed in both rubrics and marking guide.

            Show
            danmarsden Dan Marsden added a comment - assigning this back to moodle.com - this is also a problem when the rubrics grading method is selected - so either a problem with mod/assign or needs to be fixed in both rubrics and marking guide.
            Hide
            marina Marina Glancy added a comment -

            this looks like code in mod_assign javascript file

            Show
            marina Marina Glancy added a comment - this looks like code in mod_assign javascript file
            Hide
            poltawski Dan Poltawski added a comment -

            Pulling this straight into integration

            Show
            poltawski Dan Poltawski added a comment - Pulling this straight into integration
            Hide
            poltawski Dan Poltawski added a comment -

            Integrated, thanks

            Show
            poltawski Dan Poltawski added a comment - Integrated, thanks
            Hide
            phalacee Jason Fowler added a comment -

            All good now

            Show
            phalacee Jason Fowler added a comment - All good now
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.

            Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.

            Many thanks for your collaboration!

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3. Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish. Many thanks for your collaboration! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12