Moodle
  1. Moodle
  2. MDL-33476

Extra instructions required for configuring a Dropbox repository

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide

      This test requires the Dropbox repository to be enabled and a Dropbox account for use in testing.

      1. Login as a student and go to a forum.
      2. Add a new discussion topic and click the Add button to add an attachment.
      3. Choose Dropbox in the file picker then click the Login button.
      4. Grant access to your Dropbox account.
      5. Select a file then click the 'Post to forum' button.
      6. Check that the Dropbox file is shown as an attachment to the post.
      7. Try downloading the file.

      Show
      This test requires the Dropbox repository to be enabled and a Dropbox account for use in testing. 1. Login as a student and go to a forum. 2. Add a new discussion topic and click the Add button to add an attachment. 3. Choose Dropbox in the file picker then click the Login button. 4. Grant access to your Dropbox account. 5. Select a file then click the 'Post to forum' button. 6. Check that the Dropbox file is shown as an attachment to the post. 7. Try downloading the file.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      When configuring a Dropbox repository, Moodle will only work with a Dropbox app that is configured to for the whole of Dropbox. The default option when creating a Dropbox app is to allow it access to a single folder within the user's Dropbox. If the default option is used when an attempt is made to access a Dropbox repository to upload files, Moodle gives the error:

      "Remote repository returned error: Full Dropbox access attempt failed because this app is not configured to have full Dropbox access. Should your access type be app folder ('sandbox') instead?"

      Update repository/dropbox/lang/en/repository_dropbox.php, $string['instruction'] so that these instructions are displayed on the Dropbox configuration page.

      Test Steps:
      1. Login to Moodle as admin.
      2. Navigate to Settings > Site administration > Plugins > Repositories > Manage Repositories.
      3. Select "Enabled and visible" for the Dropbox repository and then click "Settings".

      Expected Result:

      • Instructions are visible onscreen informing the admin user that they must select the option "Full Dropbox - Your app needs access to the user's entire Dropbox." when setting up a Dropbox app.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Tim Barker added a comment -

            Modified repository/dropbox/lang/en/repository_dropbox.php, $string['instruction'] from "You can get your API Key and secret from Dropbox developers." to "You can get your API Key and secret from Dropbox developers. When setting up your key please select "Full Dropbox" as the Access Level."

            Show
            Tim Barker added a comment - Modified repository/dropbox/lang/en/repository_dropbox.php, $string ['instruction'] from "You can get your API Key and secret from Dropbox developers." to "You can get your API Key and secret from Dropbox developers. When setting up your key please select "Full Dropbox" as the Access Level."
            Hide
            Ankit Agarwal added a comment - - edited

            Hi Tim,

            Patch looks great! great work!
            Just two small things you need to change:-

            1. Commit message should contain the component so something like:-

              MDL-33476 repositories: Added instructions to assist with setting up Dropbox keys
              

            2. 'Access Level' should be changed to 'access level'

            Thanks

            Show
            Ankit Agarwal added a comment - - edited Hi Tim, Patch looks great! great work! Just two small things you need to change:- Commit message should contain the component so something like:- MDL-33476 repositories: Added instructions to assist with setting up Dropbox keys 'Access Level' should be changed to 'access level' Thanks
            Hide
            Tim Barker added a comment -

            "Access level" is a field label. I've modified the string so that it is a direct quote of the label i.e. "Access level". The A is capitalised and the l is not. I have added double quotation marks to indicate that this is a direct quote form the Dropbox website.

            Will use the correct commit message this time.

            Show
            Tim Barker added a comment - "Access level" is a field label. I've modified the string so that it is a direct quote of the label i.e. "Access level". The A is capitalised and the l is not. I have added double quotation marks to indicate that this is a direct quote form the Dropbox website. Will use the correct commit message this time.
            Hide
            Ankit Agarwal added a comment -

            Awesome!
            Everything good
            +1 of the integration.

            Show
            Ankit Agarwal added a comment - Awesome! Everything good +1 of the integration.
            Hide
            Ankit Agarwal added a comment -

            @integrator

            This should be a clean cherry-pick to 21 and 22

            Thanks

            Show
            Ankit Agarwal added a comment - @integrator This should be a clean cherry-pick to 21 and 22 Thanks
            Hide
            Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Dan Poltawski added a comment -

            Thanks Tim,

            I've integrated this now.

            Show
            Dan Poltawski added a comment - Thanks Tim, I've integrated this now.
            Hide
            Frédéric Massart added a comment -

            Works great! Good job!

            Show
            Frédéric Massart added a comment - Works great! Good job!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.

            Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.

            Many thanks for your collaboration!

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3. Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish. Many thanks for your collaboration! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: