Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course
    • Labels:
    • Rank:
      41382

      Description

      Smoother curves, shadows and fonts.

        Issue Links

          Activity

          Hide
          Martin Dougiamas added a comment -

          Code moved here from parent.

          Show
          Martin Dougiamas added a comment - Code moved here from parent.
          Hide
          Barbara Ramiro added a comment - - edited

          Andrew, when .modchooser was changed to .chooserdiagloge some styles didnt work in IE so I needed to add !important. Well i could be wrong but thats the first thing I noticed. I wonder if Marina's comment on MDL-32764 could be applied here to avoid using !important. Also please read the comment here https://github.com/barbararamiro/moodle/commit/5e2843481167ab0c865fed35fbdad0dcb2a14184.

          Show
          Barbara Ramiro added a comment - - edited Andrew, when .modchooser was changed to .chooserdiagloge some styles didnt work in IE so I needed to add !important. Well i could be wrong but thats the first thing I noticed. I wonder if Marina's comment on MDL-32764 could be applied here to avoid using !important. Also please read the comment here https://github.com/barbararamiro/moodle/commit/5e2843481167ab0c865fed35fbdad0dcb2a14184 .
          Hide
          Dan Poltawski added a comment -

          I have integrated this.

          There is the !important issue, but I am going to create a new issue for that so that we can get this nice style out there and tested.

          Show
          Dan Poltawski added a comment - I have integrated this. There is the !important issue, but I am going to create a new issue for that so that we can get this nice style out there and tested.
          Hide
          Dan Poltawski added a comment -

          The !important issue is MDL-33584 (and don't be fooled, it really is important )

          Show
          Dan Poltawski added a comment - The !important issue is MDL-33584 (and don't be fooled, it really is important )
          Hide
          Dan Poltawski added a comment -

          Attaching screenshot of this in IE9. Note the imperfect corners and border around it.

          Show
          Dan Poltawski added a comment - Attaching screenshot of this in IE9. Note the imperfect corners and border around it.
          Hide
          Dan Poltawski added a comment -

          I tested this on Firefox, Chrome and Safari where it looked the same and perefect.

          On IE9 there were slight imperfections as i've just uploaded in screenshot. I think these are relatively minor though, so passing this.

          Show
          Dan Poltawski added a comment - I tested this on Firefox, Chrome and Safari where it looked the same and perefect. On IE9 there were slight imperfections as i've just uploaded in screenshot. I think these are relatively minor though, so passing this.
          Hide
          Barbara Ramiro added a comment -

          Dan, imperfection removed with !important. I know you hate it but it will eventually be removed.

          Show
          Barbara Ramiro added a comment - Dan, imperfection removed with !important. I know you hate it but it will eventually be removed.
          Hide
          Frédéric Massart added a comment -

          Discovered a little issue when enabling Assignment 2.2

          Show
          Frédéric Massart added a comment - Discovered a little issue when enabling Assignment 2.2
          Hide
          Andrew Nicols added a comment -

          Assume that you mean the radio buttons for assignment 2.2 are too far to the left (agreed). This issue should probably be assigned to Barbara rather than myself - she's been handling the theming side of things.

          Show
          Andrew Nicols added a comment - Assume that you mean the radio buttons for assignment 2.2 are too far to the left (agreed). This issue should probably be assigned to Barbara rather than myself - she's been handling the theming side of things.
          Hide
          Dan Poltawski added a comment -

          Fred - please file a new issue.

          Show
          Dan Poltawski added a comment - Fred - please file a new issue.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3.

          Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish.

          Many thanks for your collaboration!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - We could celebrate it today... but better if we perform a bigger party after releasing Moodle 2.3. Print this message and come to Perth that day, it's valid for one beer, wine, coke or... water, as you wish. Many thanks for your collaboration! Ciao
          Hide
          Dan Poltawski added a comment -

          I'm creating a new issue to integrate the extra commit which didn't get integrated fixing IE

          Show
          Dan Poltawski added a comment - I'm creating a new issue to integrate the extra commit which didn't get integrated fixing IE
          Hide
          Mary Evans added a comment -

          @Barbara

          I would just like to query two of the rules set in the CSS changes to theme/base/core.css

          .moodle-dialogue-base .moodle-dialogue {
              background-color: transparent!important;
              border: 0px solid transparent!important;
          }
          

          Firstly, TRANSPARENT is NOT a color, it is the DEFAULT setting for the BACKGROUND property ONLY, so adding !important in this context is not necessary, indeed it is to be avoided.

          Secondly, since TRANSPARENT is not a color, border: 0 solid transparent!important is not valid, since a border with NO width does not exist, so has not need for a style nor a color.

          So the above rules would be better written like so...

          .moodle-dialogue-base .moodle-dialogue {
              background: none;
              border: 0 none;
          }
          
          Show
          Mary Evans added a comment - @Barbara I would just like to query two of the rules set in the CSS changes to theme/base/core.css .moodle-dialogue-base .moodle-dialogue { background-color: transparent!important; border: 0px solid transparent!important; } Firstly, TRANSPARENT is NOT a color, it is the DEFAULT setting for the BACKGROUND property ONLY, so adding !important in this context is not necessary, indeed it is to be avoided. Secondly, since TRANSPARENT is not a color, border: 0 solid transparent!important is not valid, since a border with NO width does not exist, so has not need for a style nor a color. So the above rules would be better written like so... .moodle-dialogue-base .moodle-dialogue { background: none; border: 0 none; }
          Hide
          Barbara Ramiro added a comment -

          Thanks Mary, it's been revised under MDL-33661 but I can't make it work on IE9 without !important.

          Show
          Barbara Ramiro added a comment - Thanks Mary, it's been revised under MDL-33661 but I can't make it work on IE9 without !important.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: