Moodle
  1. Moodle
  2. MDL-33518

Teacher can no longer see response file in advanced upload of files when grade overridden in gradebook

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.2.2
    • Fix Version/s: None
    • Component/s: Assignment (2.2), Gradebook
    • Labels:
    • Affected Branches:
      MOODLE_22_STABLE
    • Rank:
      41423

      Description

      Replication steps:

      1. upload a response file in advanced upload of files activity
      2. manually over-ride the grade in the gradebook

      A student still has the capability to view the response file but the teacher can no longer view it so this is misleading. Teacher thinks the response file is no longer accessible by the student.

      Sorry if I have duplicated ... the closest I could find to this are these: (not sure if they are related)

      http://tracker.moodle.org/browse/MDL-31808
      http://tracker.moodle.org/browse/MDL-27520

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for reporting that. I was able to replicate the situation you reported.

        I don't think this is a duplicate.

        Show
        Michael de Raadt added a comment - Thanks for reporting that. I was able to replicate the situation you reported. I don't think this is a duplicate.
        Hide
        Jason Cashel added a comment -

        This seems to also happen when grading is "Locked".

        The problem seems to be in moodle/mod/assignment/lib.php .

        As a temporary solution we have done below, but it would be nice if the response files were read only (like in the student view), but the filemanager element doesn't seem to support that.

        function add_feedback_section() {
        global $OUTPUT;
        $mform =& $this->_form;
        $mform->addElement('header', 'Feed Back', get_string('feedback', 'grades'));

        if ($this->_customdata->gradingdisabled) {
        $mform->addElement('static', 'disabledfeedback', $this->_customdata->grading_info->items[0]>grades[$this->_customdata->userid]>str_feedback );

        /***********Copied from below in the else***************************/
        switch ($this->_customdata->assignment->assignmenttype)

        { case 'upload' : case 'uploadsingle' : $mform->addElement('filemanager', 'files_filemanager', get_string('responsefiles', 'assignment'). ':', null, $this->_customdata->fileui_options); break; default : break; }

        /**********************************************************************/

        } else {
        // visible elements

        $mform->addElement('editor', 'submissioncomment_editor', get_string('feedback', 'assignment').':', null, $this->get_editor_options() );
        $mform->setType('submissioncomment_editor', PARAM_RAW); // to be cleaned before display
        $mform->setDefault('submissioncomment_editor', $this->_customdata->submission->submissioncomment);
        //$mform->addRule('submissioncomment', get_string('required'), 'required', null, 'client');
        switch ($this->_customdata->assignment->assignmenttype)

        { case 'upload' : case 'uploadsingle' : $mform->addElement('filemanager', 'files_filemanager', get_string('responsefiles', 'assignment'). ':', null, $this->_customdata->fileui_options); break; default : break; }

        $mform->addElement('hidden', 'mailinfo_h', "0");
        $mform->setType('mailinfo_h', PARAM_INT);
        $mform->addElement('checkbox', 'mailinfo',get_string('enablenotification','assignment').
        $OUTPUT->help_icon('enablenotification', 'assignment') .':' );
        $mform->setType('mailinfo', PARAM_INT);
        }
        }

        Show
        Jason Cashel added a comment - This seems to also happen when grading is "Locked". The problem seems to be in moodle/mod/assignment/lib.php . As a temporary solution we have done below, but it would be nice if the response files were read only (like in the student view), but the filemanager element doesn't seem to support that. function add_feedback_section() { global $OUTPUT; $mform =& $this->_form; $mform->addElement('header', 'Feed Back', get_string('feedback', 'grades')); if ($this->_customdata->gradingdisabled) { $mform->addElement('static', 'disabledfeedback', $this->_customdata->grading_info->items [0] >grades [$this->_customdata->userid] >str_feedback ); /*********** Copied from below in the else ***************************/ switch ($this->_customdata->assignment->assignmenttype) { case 'upload' : case 'uploadsingle' : $mform->addElement('filemanager', 'files_filemanager', get_string('responsefiles', 'assignment'). ':', null, $this->_customdata->fileui_options); break; default : break; } /**********************************************************************/ } else { // visible elements $mform->addElement('editor', 'submissioncomment_editor', get_string('feedback', 'assignment').':', null, $this->get_editor_options() ); $mform->setType('submissioncomment_editor', PARAM_RAW); // to be cleaned before display $mform->setDefault('submissioncomment_editor', $this->_customdata->submission->submissioncomment); //$mform->addRule('submissioncomment', get_string('required'), 'required', null, 'client'); switch ($this->_customdata->assignment->assignmenttype) { case 'upload' : case 'uploadsingle' : $mform->addElement('filemanager', 'files_filemanager', get_string('responsefiles', 'assignment'). ':', null, $this->_customdata->fileui_options); break; default : break; } $mform->addElement('hidden', 'mailinfo_h', "0"); $mform->setType('mailinfo_h', PARAM_INT); $mform->addElement('checkbox', 'mailinfo',get_string('enablenotification','assignment'). $OUTPUT->help_icon('enablenotification', 'assignment') .':' ); $mform->setType('mailinfo', PARAM_INT); } }
        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this issue.

        We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported.

        If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed.

        Michael d.

        TW9vZGxlDQo=

        Show
        Michael de Raadt added a comment - Thanks for reporting this issue. We have detected that this issue has been inactive for over a year. It was reported as affecting versions that are no longer supported. If you believe that this issue is still relevant to current versions (2.5 and beyond), please comment on the issue. Issues left inactive for a further month will be closed. Michael d. TW9vZGxlDQo=
        Hide
        Michael de Raadt added a comment -

        I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported.

        This is being done as part of a bulk annual clean-up of issues.

        If you still believe this is an issue in supported versions, please create a new issue.

        Show
        Michael de Raadt added a comment - I'm closing this issue as it has been inactive for over a year has been recorded as affecting versions that are no longer supported. This is being done as part of a bulk annual clean-up of issues. If you still believe this is an issue in supported versions, please create a new issue.

          People

          • Votes:
            3 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: