Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33521

Correct invalid CSS in core styles.css files

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.1
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      Check some or all of the following areas to make sure styles arn't obviously broken using the standard theme.

      • admin/tool/health
      • community block
      • grader report
      • glossary
      • quiz
      • wiki
      • workshop
      • admin setting (any)
      • admin colour picker (check formal white settings page)
      Show
      Check some or all of the following areas to make sure styles arn't obviously broken using the standard theme. admin/tool/health community block grader report glossary quiz wiki workshop admin setting (any) admin colour picker (check formal white settings page)
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-33521-m24

      Description

      There are several instances of invalid CSS within styles.css in core.
      This bug is about fixing those up before the release of 2.3

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              samhemelryk Sam Hemelryk added a comment -

              Starting development. I will fix there while I work on MDL-33468

              Show
              samhemelryk Sam Hemelryk added a comment - Starting development. I will fix there while I work on MDL-33468
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Putting this up for peer-review now.

              Show
              samhemelryk Sam Hemelryk added a comment - Putting this up for peer-review now.
              Hide
              fred Frédéric Massart added a comment -

              Looks good to me, feel free to submit that for integration.

              Show
              fred Frédéric Massart added a comment - Looks good to me, feel free to submit that for integration.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks for looking at this Fred, up for integration now

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks for looking at this Fred, up for integration now
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Updated for 2.4dev, added branch to backport to 2.3.1 so that this can land before that release.

              Show
              samhemelryk Sam Hemelryk added a comment - Updated for 2.4dev, added branch to backport to 2.3.1 so that this can land before that release.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Looks, perfect, thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Looks, perfect, thanks!
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Look good, can't spot any problem in suggested sections.
              Thanks for fixing this, Sam.

              Show
              rajeshtaneja Rajesh Taneja added a comment - Look good, can't spot any problem in suggested sections. Thanks for fixing this, Sam.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Congratulations your code is upstream - gold star for you!

              This issue + 79 others made it in in time for the minor releases.
              Thank you everyone involved for your exuberant efforts.

              Show
              samhemelryk Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jul/12