Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.1
    • Component/s: Filepicker
    • Labels:

      Description

      Barbara, there are some small things about filepicker/filemanager design I've noticed:

      1. If the repository allows inserting by link (from tinymce editor insert image from URL downloader or Wikimedia), when I change radio buttons they jump left or right

      2. can you please set .fp-dimensions.fp-unknown

      {display:none;}

      . Maybe for some other .fp-unknown as well but "Dimensions:" for non-image files just look awkward

      3. Please make sure that when file is a source, the list of references is displayed nicely in filemanager (text "Alias/shortcuts" should be aligned to the top, list should not have white background. Also the loading icon does not appear there any more for some reason.

      4. We still use two types of loading icons, and the big one is not very attractive. Maybe we should just use one of them? And also when filemanager is re-loading, it would look nicer if it was in the center not in the top.

        Gliffy Diagrams

          Attachments

          1. 1.png
            1.png
            30 kB
          2. 2.png
            2.png
            42 kB
          3. 3.png
            3.png
            70 kB
          4. 4a.png
            4a.png
            42 kB
          5. 4b.png
            4b.png
            27 kB
          6. 4c.png
            4c.png
            73 kB
          7. bigwindow1.png
            bigwindow1.png
            65 kB
          8. bigwindow2.png
            bigwindow2.png
            64 kB
          9. whitebackground.png
            whitebackground.png
            49 kB

            Issue Links

              Activity

              Hide
              marina Marina Glancy added a comment -

              Barbara, you may want to temporarily add

              sleep(5);

              in repository/draftfiles_ajax.php in the end of file, after
              case 'getoriginal':
              and
              case 'getreferences':
              to test the loading icon for originals/references
              (just don't forget to remove it before commit )

              Show
              marina Marina Glancy added a comment - Barbara, you may want to temporarily add sleep(5); in repository/draftfiles_ajax.php in the end of file, after case 'getoriginal': and case 'getreferences': to test the loading icon for originals/references (just don't forget to remove it before commit )
              Hide
              barbararamiro Barbara Ramiro added a comment -

              Everything on the list has been fixed, i supposed.

              Show
              barbararamiro Barbara Ramiro added a comment - Everything on the list has been fixed, i supposed.
              Hide
              poltawski Dan Poltawski added a comment -

              Closing this if its been fixed

              Show
              poltawski Dan Poltawski added a comment - Closing this if its been fixed
              Hide
              poltawski Dan Poltawski added a comment -

              Somehow I think I closed this mistakenly.

              Show
              poltawski Dan Poltawski added a comment - Somehow I think I closed this mistakenly.
              Hide
              poltawski Dan Poltawski added a comment -

              Hi Barbara,

              These changes aren't applying cleanly against master - there seem to be conflicts in the css file. Reopening.

              Show
              poltawski Dan Poltawski added a comment - Hi Barbara, These changes aren't applying cleanly against master - there seem to be conflicts in the css file. Reopening.
              Hide
              cibot CiBoT added a comment -

              Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

              Show
              cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
              Hide
              poltawski Dan Poltawski added a comment -

              I think this issue resolves MDL-34126

              Show
              poltawski Dan Poltawski added a comment - I think this issue resolves MDL-34126
              Hide
              barbararamiro Barbara Ramiro added a comment -

              Dan, i tried to resolved the conflicts. Please have a look.

              Show
              barbararamiro Barbara Ramiro added a comment - Dan, i tried to resolved the conflicts. Please have a look.
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated, thanks Barbara.

              Show
              poltawski Dan Poltawski added a comment - Integrated, thanks Barbara.
              Hide
              poltawski Dan Poltawski added a comment -

              Marina, could you test this one since you created it?

              Show
              poltawski Dan Poltawski added a comment - Marina, could you test this one since you created it?
              Hide
              marina Marina Glancy added a comment -

              I still get the white background and for some reason the info window is too wide (see screenshot)

              Show
              marina Marina Glancy added a comment - I still get the white background and for some reason the info window is too wide (see screenshot)
              Hide
              marina Marina Glancy added a comment -

              somebody put in filemanager.css

              .filemanager {
                width: 680px;
                min-width: 410px;
              }

              and it made all windows extra wide. But this was done not in this issue

              Show
              marina Marina Glancy added a comment - somebody put in filemanager.css .filemanager { width: 680px; min-width: 410px; } and it made all windows extra wide. But this was done not in this issue
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Aha, the "culprit" for that style is MDL-33303... I've already commented there looking for a solution to the width problem.

              Should we consider the "white background" a cause for failing (reverting) this? Hope no.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Aha, the "culprit" for that style is MDL-33303 ... I've already commented there looking for a solution to the width problem. Should we consider the "white background" a cause for failing (reverting) this? Hope no.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              MDL-33303 has been reverted so window widths are back to normal.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - MDL-33303 has been reverted so window widths are back to normal.
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Hi guys,

              MDL-33303 has been reverted now and I've been through looking at this issue.
              Everything appears as suggested by the screenshots and I've double checked what I assume it the white background being mentioned (is light grey).

              Passing now.

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Hi guys, MDL-33303 has been reverted now and I've been through looking at this issue. Everything appears as suggested by the screenshots and I've double checked what I assume it the white background being mentioned (is light grey). Passing now. Cheers Sam
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Congratulations your code is upstream - gold star for you!

              This issue + 79 others made it in in time for the minor releases.
              Thank you everyone involved for your exuberant efforts.

              Show
              samhemelryk Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jul/12