[MDL-33548] Quiz comment.php fails to validate the grade that was input, leading to a weird error. - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/timhunt/moodle.git
Pull Master Branch:
~~MDL-33548~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-33548
Testing Instructions:

Hide

1. As teacher: Created a quiz with a single essay question
2. As student: Attempted quiz
3. As teacher: reviewed attempt, clicked 'Make comment or override mark' to get to: http://oracle/moodle/mod/quiz/comment.php
4. Attempted to mark the answer by adding a comment and writing adding a mark greater than the maximum mark
5. Form would warn about mark added greater than maximum mark.
6. Now correct the mark to be in range, and try saving again. It should work.

Show
1. As teacher: Created a quiz with a single essay question 2. As student: Attempted quiz 3. As teacher: reviewed attempt, clicked 'Make comment or override mark' to get to: http://oracle/moodle/mod/quiz/comment.php 4. Attempted to mark the answer by adding a comment and writing adding a mark greater than the maximum mark 5. Form would warn about mark added greater than maximum mark. 6. Now correct the mark to be in range, and try saving again. It should work.

While running ~~MDLQA-2517~~ I did the following:

As teacher: Created a quiz with a single essay question
As student: Attempted quiz
As teacher: reviewed attempt, clicked 'Make comment or override mark' to get to: http://oracle/moodle/mod/quiz/comment.php
Attempted to mark the answer by adding a comment and writing adding a mark greater than the maximum mark

Expected result:

Actual result:

Blank screen returned, error log says: [Wed Jun 06 02:59:44 2012] [error] [client 192.168.195.1] Database transaction aborted automatically in /server/workspace/moodle/mod/quiz/comment.php, referer: http://oracle/moodle/mod/quiz/comment.php?attempt=1&slot=1

has a non-specific relationship to

MDL-33565 Better error message if you try to pass an object as $debuginfo for an exception

is duplicated by

MDL-31770 Need better validation of input when doing manual grading

Testing discovered

MDLQA-2517 CLONE - Smoke test of Moodle on Oracle with Apache

Participants:: Aparup Banerjee, Dan Poltawski, Eloy Lafuente (stronk7), kiliansinger, Tim Hunt

Component watchers:: Tim Hunt, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie