Moodle
  1. Moodle
  2. MDL-33573

Add an activity or resource link needs visual indication of when it becomes clickable.

    Details

    • Testing Instructions:
      Hide

      This needs to be tried in as many browsers as possible and with the JS console open to check for errors

      • Open the course page
      • Turn editing on
      • Try and click on the text before it converts to a link
      • Try and click on the text when it becomes a link
      • Ensure:
        • no errors are shown in the error console
        • the non-link text does nothing
        • the link text opens the chooser
      Show
      This needs to be tried in as many browsers as possible and with the JS console open to check for errors Open the course page Turn editing on Try and click on the text before it converts to a link Try and click on the text when it becomes a link Ensure: no errors are shown in the error console the non-link text does nothing the link text opens the chooser
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33573-master-1
    • Rank:
      41502

      Description

      When you load the course page, the links to "Add an activity or resource" are not clickable until the javascript has finished loading (which can take several seconds).

      It would be nice if they were disabled or the link decoration was removed until they become clickable (and still function normally without javascript).

      This is minor - it's just slightly annoying.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Thanks for reporting that, Damyon. I've been slightly annoyed when I've clicked the "Add an activity or resource" link too soon and nothing has happened.

          It might be tricky to sort this out while maintaining no-JS compatability.

          Show
          Michael de Raadt added a comment - Thanks for reporting that, Damyon. I've been slightly annoyed when I've clicked the "Add an activity or resource" link too soon and nothing has happened. It might be tricky to sort this out while maintaining no-JS compatability.
          Hide
          Andrew Nicols added a comment -

          Converting the anchor to a span in HTML, and then converting it back again when the JS is ready. The change is relatively seemless, but enough that you can tell there's a change.

          Show
          Andrew Nicols added a comment - Converting the anchor to a span in HTML, and then converting it back again when the JS is ready. The change is relatively seemless, but enough that you can tell there's a change.
          Hide
          Andrew Davis added a comment -

          Will this degrade gracefully if JS is enabled on the server but is disabled in the browser? Or will the user be stuck with a bunch of non-functional UI elements?

          Assuming we handle that scenario, submit for integration whenever you're ready.

          Show
          Andrew Davis added a comment - Will this degrade gracefully if JS is enabled on the server but is disabled in the browser? Or will the user be stuck with a bunch of non-functional UI elements? Assuming we handle that scenario, submit for integration whenever you're ready.
          Hide
          Andrew Nicols added a comment - - edited

          Hi Andrew,

          If JS is disabled in the browser, then the link is never shown - only the dropdowns. We make use of the .js class on the page body which is added by JS early in the page load.

          Submitting for integration.

          Show
          Andrew Nicols added a comment - - edited Hi Andrew, If JS is disabled in the browser, then the link is never shown - only the dropdowns. We make use of the .js class on the page body which is added by JS early in the page load. Submitting for integration.
          Hide
          Dan Poltawski added a comment -

          I thought it'd be too startling, but actually it seems to work OK so i've integrated it. We'll see what the masses think.

          Show
          Dan Poltawski added a comment - I thought it'd be too startling, but actually it seems to work OK so i've integrated it. We'll see what the masses think.
          Hide
          Dan Poltawski added a comment -

          I've tested this in a few browsers. continuining in more.

          Show
          Dan Poltawski added a comment - I've tested this in a few browsers. continuining in more.
          Hide
          Damyon Wiese added a comment -

          Thanks Andrew, I like it!

          Show
          Damyon Wiese added a comment - Thanks Andrew, I like it!
          Hide
          Dan Poltawski added a comment -

          (For the records, tested in IE9, firefox, chrome, safari, opera)

          Show
          Dan Poltawski added a comment - (For the records, tested in IE9, firefox, chrome, safari, opera)
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has been spread to every git and cvs repository out there, just in time to roll Moodle 2.3beta!

          Thanks! Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has been spread to every git and cvs repository out there, just in time to roll Moodle 2.3beta! Thanks! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: