Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33576

Quickgrading when assignment set to "No grade" should not allow setting of a grade.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an instance of the new Assignment module in a course.
      2. Set the "Grade" for the assignment to "No grade".
      3. Go to the grading page: "View/grade all submissions"
      4. Enable quickgrading
      5. Verify that in the grading column there is no text input to update the grade
      Show
      Create an instance of the new Assignment module in a course. Set the "Grade" for the assignment to "No grade". Go to the grading page: "View/grade all submissions" Enable quickgrading Verify that in the grading column there is no text input to update the grade
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      Currently when quickgrading is enabled for an assignment (mod_assign) set to no grade, the grade input is still showing which allows a grader to set a grade for the submission. This should be hidden if the grade is set to "No grade".

        Gliffy Diagrams

          Activity

          Hide
          samhemelryk Sam Hemelryk added a comment -

          All looks good and works as expected thanks Damyon, putting this up for integration now.

          Show
          samhemelryk Sam Hemelryk added a comment - All looks good and works as expected thanks Damyon, putting this up for integration now.
          Hide
          poltawski Dan Poltawski added a comment -

          Hi Damyon,

          This is colliding with changes MDL-33572

          It'd be great if you could confirm that this is fine, and provide a patch on top of integration.

          Show
          poltawski Dan Poltawski added a comment - Hi Damyon, This is colliding with changes MDL-33572 It'd be great if you could confirm that this is fine, and provide a patch on top of integration.
          Hide
          damyon Damyon Wiese added a comment -

          OK - I'm about to shoot off so I'll look at this first thing tomorrow.

          Regards, Damyon

          Show
          damyon Damyon Wiese added a comment - OK - I'm about to shoot off so I'll look at this first thing tomorrow. Regards, Damyon
          Hide
          damyon Damyon Wiese added a comment -

          Resolved conflicts with integration and pushed a new clean branch.

          Show
          damyon Damyon Wiese added a comment - Resolved conflicts with integration and pushed a new clean branch.
          Hide
          poltawski Dan Poltawski added a comment -

          Thanks, integrated now

          Show
          poltawski Dan Poltawski added a comment - Thanks, integrated now
          Hide
          ankit_frenz Ankit Agarwal added a comment -

          works as described
          Thanks

          Show
          ankit_frenz Ankit Agarwal added a comment - works as described Thanks
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12