Moodle
  1. Moodle
  2. MDL-33581

External functions: missing parameter defaults

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Critical Critical
        • Resolution: Fixed
        • Affects Version/s: 2.1, 2.2, 2.3
        • Fix Version/s: 2.1.7, 2.2.4, 2.3
        • Component/s: Web Services
        • Labels:
        • Rank:
          41512

          Description

          Go through all external functions and add missing parameter defaults. Without them internat call from this external function will fail as validate_param() will expect a value on VALUE_DEFAULT.

            Issue Links

            blocks

            Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-33529 external PHPunit tests

            • Minor - Minor loss of function where workaround is possible
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Dan Poltawski added a comment -

              Thanks Jerome, i've integrated that now

              Show
              Dan Poltawski added a comment - Thanks Jerome, i've integrated that now
              Hide
              Permalink
              Dan Poltawski added a comment -

              Tested by verifying the optional nature in:

              get_course_contents_parameters
              get_courses_parameters
              duplicate_course_parameters
              get_enrolled_users_parameters

              Show
              Dan Poltawski added a comment - Tested by verifying the optional nature in: get_course_contents_parameters get_courses_parameters duplicate_course_parameters get_enrolled_users_parameters
              Hide
              Permalink
              Eloy Lafuente (stronk7) added a comment -

              Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

              Ciao

              Show
              Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: