Loading...

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_23_STABLE
Pull from Repository:
git://github.com/FMCorz/moodle.git
Pull Main Branch:
~~MDL-33582~~-master-integration
Pull Main Diff URL:
https://github.com/FMCorz/moodle/compare/master...MDL-33582-master-integration
Testing Instructions:
Hide

Test prerequisites

My private files with some files

A file resource with some files

Test steps

1. Go to your privates files
2. Click on each file and

make sure the button 'Set main file' is not displayed

using an HTML inspector (Firebug), unhide the button and make sure clicking on it does not do anything

3. Go to the file resource

Make sure you can set one of the files to main file

Make sure you can change the main file

Save your changes and confirm it happened
Show
Test prerequisites My private files with some files A file resource with some files Test steps 1. Go to your privates files 2. Click on each file and make sure the button 'Set main file' is not displayed using an HTML inspector (Firebug), unhide the button and make sure clicking on it does not do anything 3. Go to the file resource Make sure you can set one of the files to main file Make sure you can change the main file Save your changes and confirm it happened

Replication steps:-

Goto to edit private files area
Open file manager and edit the css to remove "display:none" attribute on the "set as main file" button
Now "set as main file" button is visible which should not be. Clicking on the button actually works and sets the current file as main file which should not be happening.
I was also able to see "link to file directly" option following the same method in some cases, but was not really able to get that working. In any case both situations should be investigated.

Participants:: Ankit Agarwal, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Jason Fowler, Marina Glancy, Michael de Raadt