Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32999 META: Files UI Stage 2 polishing in master
  3. MDL-33582

"set as main file" option can be used when not allowed

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Files API
    • Labels:
    • Testing Instructions:
      Hide

      Test prerequisites

      1. My private files with some files
      2. A file resource with some files

      Test steps

      1. Go to your privates files
      2. Click on each file and

      • make sure the button 'Set main file' is not displayed
      • using an HTML inspector (Firebug), unhide the button and make sure clicking on it does not do anything

      3. Go to the file resource

      • Make sure you can set one of the files to main file
      • Make sure you can change the main file
      • Save your changes and confirm it happened
      Show
      Test prerequisites My private files with some files A file resource with some files Test steps 1. Go to your privates files 2. Click on each file and make sure the button 'Set main file' is not displayed using an HTML inspector (Firebug), unhide the button and make sure clicking on it does not do anything 3. Go to the file resource Make sure you can set one of the files to main file Make sure you can change the main file Save your changes and confirm it happened
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33582-master-integration

      Description

      Replication steps:-

      1. Goto to edit private files area
      2. Open file manager and edit the css to remove "display:none" attribute on the "set as main file" button
      3. Now "set as main file" button is visible which should not be. Clicking on the button actually works and sets the current file as main file which should not be happening.
      4. I was also able to see "link to file directly" option following the same method in some cases, but was not really able to get that working. In any case both situations should be investigated.

        Attachments

          Activity

            People

            Assignee:
            fred Frédéric Massart
            Reporter:
            ankit_frenz Ankit Agarwal
            Peer reviewer:
            Marina Glancy
            Integrator:
            Dan Poltawski
            Tester:
            Jason Fowler
            Participants:
            Component watchers:
            Matteo Scaramuccia, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              25/Jun/12