[MDL-33583] keep all automated backups deletes all automated backups instead - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Fixed Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w23_~~MDL-33583~~_m23_keepall
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/c9978ce67b085a90fd74a7ce6ead0ae5e76577b4...w23_MDL-33583_m23_keepall
Testing Instructions:

Hide

1/ configure backups keep all automated backups
2/ execute a few automated backups via CLI (you may need to wait a minute between executions)
3/ verify all backups are kept

Show
1/ configure backups keep all automated backups 2/ execute a few automated backups via CLI (you may need to wait a minute between executions) 3/ verify all backups are kept

backup_auto_keep ALL has value 0 and internally in code is interpreted as keep 0 backups - oops, that seems very wrong

is duplicated by

MDL-33812 backup_auto_keep not being honoured

Testing discovered

MDL-30725 Automated backups with external storage fill trashdir

Component watchers:: Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo