Moodle
  1. Moodle
  2. MDL-33588

dragdrop ingroup tests don't check whether a drop target is defined

    Details

    • Testing Instructions:
      Hide

      For regression testing, make sure that drag-drop of sections, resources and blocks still work as before after this patch is applied.

      To test the feature itself, try adding a separate drag-drop instance on the page that already uses moodle-core-dragdrop module (e.g. course/view.php). You may use MDL-33292 for testing, it will not work without this patch.

      Show
      For regression testing, make sure that drag-drop of sections, resources and blocks still work as before after this patch is applied. To test the feature itself, try adding a separate drag-drop instance on the page that already uses moodle-core-dragdrop module (e.g. course/view.php). You may use MDL-33292 for testing, it will not work without this patch.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33588-master-1

      Description

      Discovered a bug in MDL-33192 whereby event.drop is assumed to exist.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Sam Hemelryk added a comment -

            Changes look good thanks Andrew, putting this up for integration now

            Show
            Sam Hemelryk added a comment - Changes look good thanks Andrew, putting this up for integration now
            Hide
            Dan Poltawski added a comment -

            Integrated, thanks

            Show
            Dan Poltawski added a comment - Integrated, thanks
            Hide
            Dan Poltawski added a comment -

            Tested, during integration.

            Show
            Dan Poltawski added a comment - Tested, during integration.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

            Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: