Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33592

Navigation callback for local plugins should support local_ prefix.

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Navigation
    • Labels:
    • Testing Instructions:
      Hide

      Access is required to site files for this test so you'll need a local repo.

      1. Checkout Marina's moodlecheck local plugin as a submodule to your site. git submodule add git://github.com/marinaglancy/moodle-local_moodlecheck.git local/moodlecheck
      2. Download the attached lib.php file and put it into local/moodlecheck
      3. Browse to your site and log in as an admin
      4. Check you get a Moodle code check branch in the navigation.
      5. Open local/moodlecheck/lib.php and change local_moodlecheck_extends_navigation to moodlecheck_extends_navigation.
      6. Refresh the page and check you still see the Moodle code check branch.
      Show
      Access is required to site files for this test so you'll need a local repo. Checkout Marina's moodlecheck local plugin as a submodule to your site. git submodule add git://github.com/marinaglancy/moodle-local_moodlecheck.git local/moodlecheck Download the attached lib.php file and put it into local/moodlecheck Browse to your site and log in as an admin Check you get a Moodle code check branch in the navigation. Open local/moodlecheck/lib.php and change local_moodlecheck_extends_navigation to moodlecheck_extends_navigation. Refresh the page and check you still see the Moodle code check branch.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-33592-m23

      Description

      It would be nice to get this into Moodle 2.3, this issue is simply about adding support for the local_ prefix to the global navigation callback so that in future versions we can look to deprecate the current (conflict prone) callback.

      To outline the problem.
      Present callbacks:

      function nicehack_extends_navigation(global_navigation $nav);
      function local_nicehack_extends_settings_navigation(settings_navigation $nav, context $context);

      Desired callbacks:

      function local_nicehack_extends_navigation(global_navigation $nav);
      function local_nicehack_extends_settings_navigation(settings_navigation $nav, context $context);

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12