Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33618

A way to hide messages that were configured to never be sent

    Details

    • Testing Instructions:
      Hide

      UI Test (Admin should be able to disable any provider)

      1. Log in as admin
      2. Go to Site administration -> Plugins -> Message outputs -> Default message outputs
      3. You should see enabled column for each message provider and each provider should be enabled
      4. Uncheck enabled for Assignment (2.2) notifications
        • Popup notifications and email should be set to disallowed and should be disabled
        • online/not online should be unchecked and should be disabled
      5. Save changes and go to My profile settings -> Messaging
      6. You should not see Assignment 2.2 related settings
      7. Go back to Site administration -> Plugins -> Message outputs -> Default message outputs
      8. Check enabled for Assignment (2.2) notifications
        • Popup notifications and email should be set to Permitted and should not be disabled
        • online/not online should be unchecked but enabled
      9. Save changes and go to My profile settings -> Messaging
      10. You should see Assignment 2.2 related settings
      11. Try above with JS disabled and make sure if Enabled is unchceked, then after saving the provider should be set to "Disallow"

      Functionality test

      1. Log in as admin
      2. Go to Site administration -> Plugins -> Message outputs -> Default message outputs
      3. Uncheck enabled for "Badge creator notifications" and "Badge recipient notifications"
      4. Go to /admin/settings.php?section=messagesettingemail admin settings and make sure that "Allow attachments" is set to NO.
      5. Create a new badge (Site administration -> Badges -> Add a new badge) and set criteria to manually issue by role (Teacher)
      6. Under badge -> Message tab set "Notify badge creator" to "Every time"
      7. Enable badge and Award badge to user.
      8. Check mail/messages and you should not receive any notification.
      9. Go to Site administration -> Plugins -> Message outputs -> Default message outputs
      10. Enable "Badge creator notifications" and "Badge recipient notifications" and check online/not online for both processors.
      11. Award badge to user again and check mail/messages and you should see badge award notification.

      Unit test

      1. Run phpunit lib/tests/messagelib_test.php
      Show
      UI Test (Admin should be able to disable any provider) Log in as admin Go to Site administration -> Plugins -> Message outputs -> Default message outputs You should see enabled column for each message provider and each provider should be enabled Uncheck enabled for Assignment (2.2) notifications Popup notifications and email should be set to disallowed and should be disabled online/not online should be unchecked and should be disabled Save changes and go to My profile settings -> Messaging You should not see Assignment 2.2 related settings Go back to Site administration -> Plugins -> Message outputs -> Default message outputs Check enabled for Assignment (2.2) notifications Popup notifications and email should be set to Permitted and should not be disabled online/not online should be unchecked but enabled Save changes and go to My profile settings -> Messaging You should see Assignment 2.2 related settings Try above with JS disabled and make sure if Enabled is unchceked, then after saving the provider should be set to "Disallow" Functionality test Log in as admin Go to Site administration -> Plugins -> Message outputs -> Default message outputs Uncheck enabled for "Badge creator notifications" and "Badge recipient notifications" Go to /admin/settings.php?section=messagesettingemail admin settings and make sure that "Allow attachments" is set to NO. Create a new badge (Site administration -> Badges -> Add a new badge) and set criteria to manually issue by role (Teacher) Under badge -> Message tab set "Notify badge creator" to "Every time" Enable badge and Award badge to user. Check mail/messages and you should not receive any notification. Go to Site administration -> Plugins -> Message outputs -> Default message outputs Enable "Badge creator notifications" and "Badge recipient notifications" and check online/not online for both processors. Award badge to user again and check mail/messages and you should see badge award notification. Unit test Run phpunit lib/tests/messagelib_test.php
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
    • Fixed Branches:
      MOODLE_27_STABLE
    • Pull Master Branch:
      wip-mdl-33618
    • Story Points (Obsolete):
      13
    • Sprint:
      BACKEND Sprint 7

      Description

      A user can view all messages sent to him/her via Recent Notifications under My Profile > Messages. Even messages that the user has configured to not receive or the admin as forced that all users should not receive. There should be a way to suppress messages that where never actually delivered to the user.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  7 Vote for this issue
                  Watchers:
                  12 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    12/May/14