Moodle
  1. Moodle
  2. MDL-33627

If add more than 1 feedback activities on the front page, only the last appears in the feedback block

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.9, 2.2.1, 2.2.2, 2.2.3
    • Fix Version/s: 2.0.10, 2.1.7, 2.2.4, 2.3.1
    • Component/s: Feedback
    • Labels:
      None
    • Testing Instructions:
      1. You need one or more courses
      2. Create two or more feedback activities on the front page
      3. Add a feedback-block instance inside each course
      4. The block should show all feedbacks from the frontpage
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33627_master
    • Rank:
      41572

      Description

      Create 2 feedback activities on the front page and leave them both available on all courses (no mapping) >> result: all courses will show only 1 link in the block - the one that links to the 2nd activity

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for taking this on, Andreas.

        Show
        Michael de Raadt added a comment - Thanks for taking this on, Andreas.
        Hide
        Sam Hemelryk added a comment -

        Thanks Andreas, this has been integrated now.
        I tested the Moodle 20 branch just to be sure no probs there and things worked fine but I think a tester is still required to go through other branches.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Thanks Andreas, this has been integrated now. I tested the Moodle 20 branch just to be sure no probs there and things worked fine but I think a tester is still required to go through other branches. Cheers Sam
        Hide
        Adrian Greeve added a comment -

        Checked on all branches provided. All feedback activities were displayed in the feedback block.
        Just a quick note. Mentioning that the feedback module and block are default as hidden would have save me a lot of time with testing this issue.
        Test passed.

        Show
        Adrian Greeve added a comment - Checked on all branches provided. All feedback activities were displayed in the feedback block. Just a quick note. Mentioning that the feedback module and block are default as hidden would have save me a lot of time with testing this issue. Test passed.
        Hide
        Sam Hemelryk added a comment -

        Congratulations your code is upstream - gold star for you!

        This issue + 79 others made it in in time for the minor releases.
        Thank you everyone involved for your exuberant efforts.

        Show
        Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: