Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33649

Prevent page from scrolling when activity chooser is open

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course, Usability
    • Labels:
    • Testing Instructions:
      Hide

      In as many browsers as possible (at least IE and non-IE).

      • Open course page
        • Confirm that the page can be scrolled
      • Turn editing on
        • Confirm that the page can be scrolled
      • Open the activity chooser
        • Confirm that the page can no longer be scrolled
      • Close the activity chooser
        • Confirm that the page can be scrolled again
      • Move down the page a little
        • Confirm that the page can be scrolled
      • Open the activity chooser
        • Confirm that the page can no longer be scrolled
      • Close the activity chooser
        • Confirm that the page can be scrolled again

      We run the test a second time slightly further down the page to ensure that there are no weird effects if the page is not at the top.

      Show
      In as many browsers as possible (at least IE and non-IE). Open course page Confirm that the page can be scrolled Turn editing on Confirm that the page can be scrolled Open the activity chooser Confirm that the page can no longer be scrolled Close the activity chooser Confirm that the page can be scrolled again Move down the page a little Confirm that the page can be scrolled Open the activity chooser Confirm that the page can no longer be scrolled Close the activity chooser Confirm that the page can be scrolled again We run the test a second time slightly further down the page to ensure that there are no weird effects if the page is not at the top.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33649-master-2

      Description

      Eloy suggested that we should prevent the page from scrolling when the activity chooser is open, and I've just discovered how this can be done. For most browsers, it should be as simple as setting the body overflow to hidden whilst the viewer is open. IE is slightly more frustrating and needs the overflow changing to hidden for the HTML tag rather than the body tag and needs to be changed back to 'scroll' instead of 'visible'. Helpful.

      I have a patch for this, though I appreciate it's really a bit too late in the day to be integrating this for 2.3 (though it would really enhance usability if it were integrated).

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Ruslan Kabalin
              Integrator:
              Aparup Banerjee
              Tester:
              Frédéric Massart
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Barbara Ramiro, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                25/Jun/12