Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33663

Improve the error message when you enter a negative grade when using a marking guide

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.9.4, 3.0.2
    • Fix Version/s: 3.1
    • Component/s: Grading methods
    • Labels:
    • Testing Instructions:
      Hide
      1. Visit (or create) a course that has a least 1 student enrolled.
      2. Create an assignment with the 'Grading method' set to 'Marking guide'.
      3. Click on the assignment then on 'Advanced grading' under 'Assignment administration'.
      4. Click on 'Define new grading for from scatch'
      5. Under 'Maximum mark' enter a negative value and submit the form.
      6. Ensure you get the warning 'The max score is not valid, negative values are not allowed'.
      7. Fill out the form correctly and submit.
      8. Click on the assignment then on 'View/grade all submissions'.
      9. Click on the 'grade' icon next to a student.
      10. Enter a negative grade.
      11. Ensure you get the warning 'The score given to '<Criterion name>' is not valid, negative values are not allowed'.
      12. Fill out the form correctly and ensure you can submit successfully.
      Show
      Visit (or create) a course that has a least 1 student enrolled. Create an assignment with the 'Grading method' set to 'Marking guide'. Click on the assignment then on 'Advanced grading' under 'Assignment administration'. Click on 'Define new grading for from scatch' Under 'Maximum mark' enter a negative value and submit the form. Ensure you get the warning 'The max score is not valid, negative values are not allowed'. Fill out the form correctly and submit. Click on the assignment then on 'View/grade all submissions'. Click on the 'grade' icon next to a student. Enter a negative grade. Ensure you get the warning 'The score given to '<Criterion name>' is not valid, negative values are not allowed'. Fill out the form correctly and ensure you can submit successfully.
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_29_STABLE, MOODLE_30_STABLE
    • Fixed Branches:
      MOODLE_31_STABLE
    • Pull Master Branch:

      Description

      If you enter a maximum grade of 10 for a criteria the range seems to be 0-10. A negative grade is not accepted. The error message you get is "The score given to spelling is not valid, the max score is: 10" It would be nice if it told you that your grade is invalid because it is negative.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  23/May/16