Moodle
  1. Moodle
  2. MDL-33664

Coding error while publishing course on hub.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Hub
    • Labels:
    • Rank:
      41657

      Description

      while publishing the course I got following error

      Debug info: Argument 1 passed to base_ui::display() must be an instance of core_backup_renderer, none given, called in /var/www/im/course/publish/backup.php on line 84 and defined
      Error code: codingerror
      Stack trace:
      
          line 397 of /lib/setuplib.php: coding_exception thrown
          line 146 of /backup/util/ui/base_ui.class.php: call to default_error_handler()
          line 84 of /course/publish/backup.php: call to base_ui->display()
      

      Also, it might be nice to redirect user to registration page and not to Registration information page, after unregistering site from hub. (http://tracker.moodle.org/browse/MDLQA-1935?focusedCommentId=162835&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-162835)

      FYI:
      Course get published.

        Issue Links

          Activity

          Hide
          Rajesh Taneja added a comment -

          Increasing the priority as it breaks existing functionality.

          Show
          Rajesh Taneja added a comment - Increasing the priority as it breaks existing functionality.
          Hide
          Jérôme Mouneyrac added a comment -

          looks good to me. Thanks Raj.

          Show
          Jérôme Mouneyrac added a comment - looks good to me. Thanks Raj.
          Hide
          Dan Poltawski added a comment -

          Hi Raj,

          I think your huburl change is incorrect. I noticed it too when I was initially integrating this. But the huburl is set by optional_param at top?

          Show
          Dan Poltawski added a comment - Hi Raj, I think your huburl change is incorrect. I noticed it too when I was initially integrating this. But the huburl is set by optional_param at top?
          Hide
          Dan Poltawski added a comment -

          ps. Ia ssume the affected versions should actually be 2.3?

          Show
          Dan Poltawski added a comment - ps. Ia ssume the affected versions should actually be 2.3?
          Hide
          Rajesh Taneja added a comment -

          Thanks for the feedback Dan,

          huburl change was correct, I agree it was set by optional_param. But in this conditional block it is considered to be 0 (which it was not). Anyway, I have modified the code to use different variable, avoiding any further confusions.

          Hope this is acceptable.

          FYI:
          Changed affected version to 2.3

          Show
          Rajesh Taneja added a comment - Thanks for the feedback Dan, huburl change was correct, I agree it was set by optional_param. But in this conditional block it is considered to be 0 (which it was not). Anyway, I have modified the code to use different variable, avoiding any further confusions. Hope this is acceptable. FYI: Changed affected version to 2.3
          Hide
          Dan Poltawski added a comment -

          Thanks for the clarification Raj, integrated thanks.

          Show
          Dan Poltawski added a comment - Thanks for the clarification Raj, integrated thanks.
          Hide
          Dan Poltawski added a comment -

          I'm manually passing this test as is to be done by QA tests

          Show
          Dan Poltawski added a comment - I'm manually passing this test as is to be done by QA tests
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: