Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33670

A critical typo @ user_get_user_details()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.6
    • Fix Version/s: 2.1.7
    • Component/s: Libraries, Web Services
    • Labels:
      None

      Description

      In latest commit: https://github.com/moodle/moodle/commit/d099f4fd0edc4df1bf1781e6478427813bcddcb8

      Code:

          if ($isadmin
            of $currentuser

      should be

          if ($isadmin
            or $currentuser

      I think it may break web service since function user_get_user_details is called only in user/externallib.php

      I have checked all branches and it affects 2.1 branch only.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  skodak Petr Skoda
                  Reporter:
                  sunner Sunner Sun
                  Integrator:
                  Eloy Lafuente (stronk7)
                  Tester:
                  Jason Fowler
                  Participants:
                  Component watchers:
                  David Monllaó, Víctor Déniz Falcón, Juan Leyva, Jake Dallimore, Jun Pataleta
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jul/12