[MDL-33670] A critical typo @ user_get_user_details() - Moodle Tracker

XML

Word

Printable

Testing Instructions:

Hide

see ~~MDL-31520~~ test instructions - make sure this gets tested in 21 stable

Show
see MDL-31520 test instructions - make sure this gets tested in 21 stable
Affected Branches:
MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w24_~~MDL-33670~~_m21_ofadmin
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/MOODLE_21_STABLE...w24_MDL-33670_m21_ofadmin

Code:

    if ($isadmin

      of $currentuser

should be

    if ($isadmin

      or $currentuser

I think it may break web service since function user_get_user_details is called only in user/externallib.php

I have checked all branches and it affects 2.1 branch only.

is a regression caused by

MDL-31520 get_users_by_id never returns email, not even to admin user

Participants:: Eloy Lafuente (stronk7), Jason Fowler, Petr Skoda, Sunner Sun

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Sara Arjona (@sarjona), Víctor Déniz Falcón