Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.6
-
Fix Version/s: 2.1.7
-
Component/s: Libraries, Web Services
-
Labels:None
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE
-
Fixed Branches:MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:w24_
MDL-33670_m21_ofadmin -
Pull Master Diff URL:
Description
In latest commit: https://github.com/moodle/moodle/commit/d099f4fd0edc4df1bf1781e6478427813bcddcb8
Code:
if ($isadmin
|
of $currentuser
|
should be
if ($isadmin
|
or $currentuser
|
I think it may break web service since function user_get_user_details is called only in user/externallib.php
I have checked all branches and it affects 2.1 branch only.
Gliffy Diagrams
Issue Links
- is a regression caused by
-
MDL-31520
get_users_by_id never returns email, not even to admin user
-
- Closed
-
Activity
Big thanks for the report!!
Integrated, thanks!
Petr, can we please get some testing instructions for this issue?
This is a regression from MDL-31520, it seems that nobody tested it there because there was a fatal error, so test it now using the same instructions.
Tested under master and 2.1 as I was confused by the master diff branch and just wanted to be extra careful ...
Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL
Ciao 
Oh, now I see it.