Moodle

A critical typo @ user_get_user_details()

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.6
  • Fix Version/s: 2.1.7
  • Component/s: Libraries, Web Services
  • Labels:
    None

Description

In latest commit: https://github.com/moodle/moodle/commit/d099f4fd0edc4df1bf1781e6478427813bcddcb8

Code:

    if ($isadmin
      of $currentuser

should be

    if ($isadmin
      or $currentuser

I think it may break web service since function user_get_user_details is called only in user/externallib.php

I have checked all branches and it affects 2.1 branch only.

Issue Links

is a regression caused by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31520 get_users_by_id never returns email, not even to admin user

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Petr Škoda added a comment -

Oh, now I see it.

Show
Petr Škoda added a comment - Oh, now I see it.
Hide
Permalink
Petr Škoda added a comment -

Big thanks for the report!!

Show
Petr Škoda added a comment - Big thanks for the report!!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
Hide
Permalink
Jason Fowler added a comment -

Petr, can we please get some testing instructions for this issue?

Show
Jason Fowler added a comment - Petr, can we please get some testing instructions for this issue?
Hide
Permalink
Petr Škoda added a comment -

This is a regression from MDL-31520, it seems that nobody tested it there because there was a fatal error, so test it now using the same instructions.

Show
Petr Škoda added a comment - This is a regression from MDL-31520 , it seems that nobody tested it there because there was a fatal error, so test it now using the same instructions.
Hide
Permalink
Jason Fowler added a comment -

Tested under master and 2.1 as I was confused by the master diff branch and just wanted to be extra careful ...

Show
Jason Fowler added a comment - Tested under master and 2.1 as I was confused by the master diff branch and just wanted to be extra careful ...
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: