Moodle

If a section has a name of '0' you cannot backup the course

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.6, 2.2.3, 2.3
  • Fix Version/s: 2.1.7, 2.2.4
  • Component/s: Backup
  • Labels:

Description

You cannot do this with standard Moodle (see MDL-33681), but you can with the OU's course format, and backup should not throw exceptions in this case.

Issue Links

is blocked by

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-33681 Cannot have a section called 0

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

To INTEGRATORS: please integrate MDL-33681 first.

Show
Tim Hunt added a comment - To INTEGRATORS: please integrate MDL-33681 first.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Uhm, I think you're wrong @ https://github.com/timhunt/moodle/compare/MDL-33681...MDL-33682#L2R142 (and it should be === instead of !=== to keep old behavior). The others look ok.

So, I'm going to fix that and test...ciao

Show
Eloy Lafuente (stronk7) added a comment - Uhm, I think you're wrong @ https://github.com/timhunt/moodle/compare/MDL-33681...MDL-33682#L2R142 (and it should be === instead of !=== to keep old behavior). The others look ok. So, I'm going to fix that and test...ciao
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Integrated, thanks!

Show
Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Passing perfectly, yay!

Show
Eloy Lafuente (stronk7) added a comment - Passing perfectly, yay!
Hide
Permalink
Tim Hunt added a comment -

Oops! yes that was a mistake. Thank you for fixing it, and for integrating this and the other one so quickly.

Show
Tim Hunt added a comment - Oops! yes that was a mistake. Thank you for fixing it, and for integrating this and the other one so quickly.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

Ciao

Show
Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

People

  • Assignee:
    Tim Hunt
    Reporter:
    Tim Hunt
    Integrator:
    Eloy Lafuente (stronk7)
    Tester:
    Eloy Lafuente (stronk7)
    Participants:
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: