Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33682

If a section has a name of '0' you cannot backup the course

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.6, 2.2.3, 2.3
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Backup
    • Labels:

      Description

      You cannot do this with standard Moodle (see MDL-33681), but you can with the OU's course format, and backup should not throw exceptions in this case.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            timhunt Tim Hunt added a comment -

            To INTEGRATORS: please integrate MDL-33681 first.

            Show
            timhunt Tim Hunt added a comment - To INTEGRATORS: please integrate MDL-33681 first.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Uhm, I think you're wrong @ https://github.com/timhunt/moodle/compare/MDL-33681...MDL-33682#L2R142 (and it should be === instead of !=== to keep old behavior). The others look ok.

            So, I'm going to fix that and test...ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Uhm, I think you're wrong @ https://github.com/timhunt/moodle/compare/MDL-33681...MDL-33682#L2R142 (and it should be === instead of !=== to keep old behavior). The others look ok. So, I'm going to fix that and test...ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Passing perfectly, yay!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Passing perfectly, yay!
            Hide
            timhunt Tim Hunt added a comment -

            Oops! yes that was a mistake. Thank you for fixing it, and for integrating this and the other one so quickly.

            Show
            timhunt Tim Hunt added a comment - Oops! yes that was a mistake. Thank you for fixing it, and for integrating this and the other one so quickly.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

              People

              • Assignee:
                timhunt Tim Hunt
                Reporter:
                timhunt Tim Hunt
                Integrator:
                Eloy Lafuente (stronk7)
                Tester:
                Eloy Lafuente (stronk7)
                Participants:
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/12