Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.6, 2.2.3, 2.3
-
Component/s: Backup
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
-
Fixed Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
-
Rank:41680
Description
You cannot do this with standard Moodle (see MDL-33681), but you can with the OU's course format, and backup should not throw exceptions in this case.
Issue Links
- is blocked by
-
MDL-33681
Cannot have a section called 0
-
- Closed
-
Activity
Uhm, I think you're wrong @ https://github.com/timhunt/moodle/compare/MDL-33681...MDL-33682#L2R142 (and it should be === instead of !=== to keep old behavior). The others look ok.
So, I'm going to fix that and test...ciao 
Show
Eloy Lafuente (stronk7)
added a comment - Uhm, I think you're wrong @ https://github.com/timhunt/moodle/compare/MDL-33681...MDL-33682#L2R142 (and it should be === instead of !=== to keep old behavior). The others look ok.
So, I'm going to fix that and test...ciao
Integrated, thanks!
Show
Eloy Lafuente (stronk7)
added a comment - Integrated, thanks!
Passing perfectly, yay!
Show
Eloy Lafuente (stronk7)
added a comment - Passing perfectly, yay!
Oops! yes that was a mistake. Thank you for fixing it, and for integrating this and the other one so quickly.
Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL
Ciao
Show
Eloy Lafuente (stronk7)
added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL
Ciao
To INTEGRATORS: please integrate
MDL-33681first.