Moodle
  1. Moodle
  2. MDL-33703

Resizing a window or changing device orientation should adjust the chooser to still fit in the window

    Details

    • Testing Instructions:
      Hide

      Test in as many browsers as feasible. As usual, it probably helps to have the JS console open.

      In desktop browsers:

      • Ensure that the browser window is as large as possible
      • Open a course
      • Open the module chooser
        • Confirm it's centered
        • Confirm that the page does not scroll
      • Resize the page to a size slightly smaller than the chooser is currently
        • Confirm that the chooser scales as required
        • Confirm that the page still does not scroll
      • Resize the page to a pretty tiny size - until the button disappear from the chooser
        • Confirm that the chooser scales as required
        • Confirm that the page now supports scrolling so that you can view the buttons
      • Resize the page up again
        • Confirm that the chooser scales as required
        • Confirm that the page no longer scrolls
      • Resize the page down again and refresh the page
        • Confirm that the chooser scales as required
        • Confirm that the page supports scrolling so that you can view the buttons

      In a mobile browser (I only have iOS to hand):

      • Open Safari in portrait mode
      • Open a course
      • Open the module chooser
        • Confirm it's centered
        • Note: Scrolling currently does work on mobile devices
      • Change to landscape orientation
        • Confirm that the chooser re-centers
      • Change back to portrait orientation
        • Confirm that the chooser re-centers
      Show
      Test in as many browsers as feasible. As usual, it probably helps to have the JS console open. In desktop browsers: Ensure that the browser window is as large as possible Open a course Open the module chooser Confirm it's centered Confirm that the page does not scroll Resize the page to a size slightly smaller than the chooser is currently Confirm that the chooser scales as required Confirm that the page still does not scroll Resize the page to a pretty tiny size - until the button disappear from the chooser Confirm that the chooser scales as required Confirm that the page now supports scrolling so that you can view the buttons Resize the page up again Confirm that the chooser scales as required Confirm that the page no longer scrolls Resize the page down again and refresh the page Confirm that the chooser scales as required Confirm that the page supports scrolling so that you can view the buttons In a mobile browser (I only have iOS to hand): Open Safari in portrait mode Open a course Open the module chooser Confirm it's centered Note: Scrolling currently does work on mobile devices Change to landscape orientation Confirm that the chooser re-centers Change back to portrait orientation Confirm that the chooser re-centers
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33703-master-3
    • Rank:
      41709

      Description

      This is primarily for iOS devices, but also has a use when a user resizes their browser.

        Issue Links

          Activity

          Hide
          Andrew Nicols added a comment -

          Just realised that this isn't actually blocked by MDL-33649 and have removed the blocker link, and updated the patch so it's not based on the commit for MDL-33649.

          Show
          Andrew Nicols added a comment - Just realised that this isn't actually blocked by MDL-33649 and have removed the blocker link, and updated the patch so it's not based on the commit for MDL-33649 .
          Hide
          Ankit Agarwal added a comment -

          This is broken in ff.
          If you open the activity chooser and than close it.
          It wont allow you to do any scrolling on the current page at all.

          Thanks

          Show
          Ankit Agarwal added a comment - This is broken in ff. If you open the activity chooser and than close it. It wont allow you to do any scrolling on the current page at all. Thanks
          Hide
          Andrew Nicols added a comment -

          That particular breakages comes from MDL-33649 rather than MDL-33703.

          Show
          Andrew Nicols added a comment - That particular breakages comes from MDL-33649 rather than MDL-33703 .
          Hide
          Andrew Nicols added a comment -

          The breakage described is actually due to another issue - putting this back up for PR

          Show
          Andrew Nicols added a comment - The breakage described is actually due to another issue - putting this back up for PR
          Hide
          Ankit Agarwal added a comment - - edited

          Hi Andrew,
          This looks good to me.
          Feel free to submit for integration.

          PS:- Horizontal resizing of the window are taken care in MDL-33728
          Thanks

          Show
          Ankit Agarwal added a comment - - edited Hi Andrew, This looks good to me. Feel free to submit for integration. PS:- Horizontal resizing of the window are taken care in MDL-33728 Thanks
          Hide
          Dan Poltawski added a comment -

          Must we browser sniff for this?

          Show
          Dan Poltawski added a comment - Must we browser sniff for this?
          Hide
          Andrew Nicols added a comment -

          You're right - we shouldn't really test the browser type for this one otherwise we'll be breaking things for non-mobile devices supporting orientation changes in the future.

          Have resubmitted without the test after testing on:

          • iOS Safari (iPad 5.1)
          • iOS Safari (iPhone 5.1)
          • Chrome
          • Opera
          • Firefox
          • IE9
          Show
          Andrew Nicols added a comment - You're right - we shouldn't really test the browser type for this one otherwise we'll be breaking things for non-mobile devices supporting orientation changes in the future. Have resubmitted without the test after testing on: iOS Safari (iPad 5.1) iOS Safari (iPhone 5.1) Chrome Opera Firefox IE9
          Hide
          Aparup Banerjee added a comment -

          thanks, thats integrated right into the center of master.

          Show
          Aparup Banerjee added a comment - thanks, thats integrated right into the center of master.
          Hide
          Rajesh Taneja added a comment -

          Thanks for fixing this Andrew
          Works well on IE, FF, Chrome, opera, Safari and Android mobile browser and Dolphin

          NOTE:
          Screen resizing (pinch zoom in/out), doesn't allow user to move activity chooser, page slides, but activity chooser is not selectable/moving.

          Show
          Rajesh Taneja added a comment - Thanks for fixing this Andrew Works well on IE, FF, Chrome, opera, Safari and Android mobile browser and Dolphin NOTE: Screen resizing (pinch zoom in/out), doesn't allow user to move activity chooser, page slides, but activity chooser is not selectable/moving.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

          Many, many thanks for your hard work!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: