[MDL-33712] Avoid cleaning old <lang> and <nolink> tags in TinyMCE editor - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.0.9, 2.1.6, 2.2.3, 2.3
Fix Version/s: 2.2.5, 2.3.2
Component/s: Filters
Labels:
- partner
- triaged

Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/skodak/moodle.git
Pull Master Branch:
w28_~~MDL-33712~~_m24_extratags
Pull Master Diff URL:
https://github.com/skodak/moodle/compare/master...w28_MDL-33712_m24_extratags
Testing Instructions:

Hide

1/ try adding lang and nolink tags to tinymce in teacher area
2/ try adding lang and nolink tags to tinymce in teacher area
3/ it is expected that the tags are not changes on save or when switching editor view
4/ try different browsers

note: both nolink and lang tags are considered to be DIVs, so expect problems when nesting in SPANs

Show
1/ try adding lang and nolink tags to tinymce in teacher area 2/ try adding lang and nolink tags to tinymce in teacher area 3/ it is expected that the tags are not changes on save or when switching editor view 4/ try different browsers note: both nolink and lang tags are considered to be DIVs, so expect problems when nesting in SPANs

Description

Apart from any other issue about new syntaxes, problems for the multilang filter... like these:

http://tracker.moodle.org/secure/IssueNavigator.jspa?reset=true&jqlQuery=%28summary+%7E+%22%2Bfilter+%2Bmultilang%22+OR+description+%7E+%22%2Bfilter+%2Bmultilang%22+OR+comment+%7E+%22%2Bfilter+%2Bmultilang%22%29+AND+resolution+%3D+Unresolved+AND+project+%3D+Moodle+ORDER+BY+updated+ASC

Right now any <lang> (and probably <nolink>) tags in one text are being deleted by the html editor (and perhaps also by the purifier).

So this issue is exclusively about to allow them if $CFG->filter_multilang_force_old is enabled. Sort of pass-thought both in the editor and purifier.

Ciao

Attachments

Activity

People

Assignee:: Petr Skoda

Reporter:: Eloy Lafuente (stronk7)

Integrator:: Dan Poltawski

Tester:: Rajesh Taneja

Participants:: Dan Poltawski, Eloy Lafuente (stronk7), Petr Skoda, Rajesh Taneja

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Votes:: 1 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 14/Jun/12 8:49 AM

Updated:: 13/Jul/12 1:59 AM

Resolved:: 13/Jul/12 1:59 AM

Fix Release Date:: 10/Sep/12