Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33721

Filepicker button 'Select this file' should prevent double clicks

    Details

    • Testing Instructions:
      Hide
      1. Go to your private files and click to add the file
      2. Choose a file from any repository (for example, Dropbox)
      3. Click 'Select this file'
      4. Make sure you can not click the button second time (loading icon is displayed)
      Show
      Go to your private files and click to add the file Choose a file from any repository (for example, Dropbox) Click 'Select this file' Make sure you can not click the button second time (loading icon is displayed)
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      wip-MDL-33721-master

      Description

      When browsing a repository (Dropbox in my case) and selecting a file, there is no confirmation or loading screen and the button 'Select this file' is still active. Which means that each click on it will retrieve one more copy from the repository.

      Ideally a loading icon should pop and the button should be disabled.

      1. Set up your Dropbox repository
      2. Go to your private files and click add
      3. Navigate to a file in your Dropbox repository and select it
      4. Click 'Select this file'

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              salvetore Michael de Raadt added a comment -

              Double-clicking in general is a big problem, and not just in the file picker.

              Show
              salvetore Michael de Raadt added a comment - Double-clicking in general is a big problem, and not just in the file picker.
              Hide
              fred Frédéric Massart added a comment -

              Yes, but in this case, you can click once and wait two seconds and click again because the UI does not show any sign of 'loading'.
              Especially when dealing with remote repositories such as Dropbox, Wikimedia, Google Docs, etc...
              I should have set the title to 'should prevent multiple clicks and show loading icon to be consistent with overall filepicker'

              Show
              fred Frédéric Massart added a comment - Yes, but in this case, you can click once and wait two seconds and click again because the UI does not show any sign of 'loading'. Especially when dealing with remote repositories such as Dropbox, Wikimedia, Google Docs, etc... I should have set the title to 'should prevent multiple clicks and show loading icon to be consistent with overall filepicker'
              Hide
              marina Marina Glancy added a comment -

              TO INTEGRATORS: please cherry-pick to 23_STABLE

              Show
              marina Marina Glancy added a comment - TO INTEGRATORS: please cherry-pick to 23_STABLE
              Hide
              poltawski Dan Poltawski added a comment -

              Integrated, thanks!

              Show
              poltawski Dan Poltawski added a comment - Integrated, thanks!
              Hide
              ankit_frenz Ankit Agarwal added a comment -

              Works as described
              Passing!
              Thanks

              Show
              ankit_frenz Ankit Agarwal added a comment - Works as described Passing! Thanks
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Congratulations your code is upstream - gold star for you!

              This issue + 79 others made it in in time for the minor releases.
              Thank you everyone involved for your exuberant efforts.

              Show
              samhemelryk Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    9/Jul/12