Moodle
  1. Moodle
  2. MDL-33728

Activity Chooser should also centre horizontally

    Details

    • Testing Instructions:
      Hide

      After MDL-33703 has been integrated:

      • Open a course
      • Turn editing on
      • Open the Activity Chooser
        • Confirm that the chooser is centred both vertically and horizontally
      • Resize the browser window horizontally
        • Confirm that the chooser moves as the window resizes such that it is always centred
      • Resize the browser window vertically
        • Confirm that the chooser moves as the window resizes such that it is always centred
      Show
      After MDL-33703 has been integrated: Open a course Turn editing on Open the Activity Chooser Confirm that the chooser is centred both vertically and horizontally Resize the browser window horizontally Confirm that the chooser moves as the window resizes such that it is always centred Resize the browser window vertically Confirm that the chooser moves as the window resizes such that it is always centred
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33728-master-1
    • Rank:
      41758

      Description

      Ankit suggested that resizing a window should cause the chooser dialogue to resize vertically as well as horizontally.
      Please note, that resizing is added in MDL-33703 so to test resizing this needs to be present

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          @integrator
          MDL-33703 must land before this lands for proper testing of this issue.

          Show
          Ankit Agarwal added a comment - @integrator MDL-33703 must land before this lands for proper testing of this issue.
          Hide
          Ankit Agarwal added a comment -

          Hi Andrew,
          This looks good.

          Can you please add some testing instructions?

          Feel free to submit for integration.

          Thanks

          Show
          Ankit Agarwal added a comment - Hi Andrew, This looks good. Can you please add some testing instructions? Feel free to submit for integration. Thanks
          Hide
          Dan Poltawski added a comment -

          Looks simple enough, but might be risky.

          Show
          Dan Poltawski added a comment - Looks simple enough, but might be risky.
          Hide
          Aparup Banerjee added a comment -

          thanks, thats integrated into master.

          Show
          Aparup Banerjee added a comment - thanks, thats integrated into master.
          Hide
          Rajesh Taneja added a comment -

          Thanks for fixing this Andrew

          Works well on IE, FF, Chrome, Opera and Safari.

          Show
          Rajesh Taneja added a comment - Thanks for fixing this Andrew Works well on IE, FF, Chrome, Opera and Safari.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay!

          Many, many thanks for your hard work!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - And this has been incorporated to all the weekly builds and also, to Moodle 2.3 Release Candidate 1, yay! Many, many thanks for your hard work! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: