Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33729

Activity Chooser doesn't listen to [x] button and doesn't cancel some listeners sufficiently

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course, JavaScript
    • Labels:
    • Testing Instructions:
      Hide

      Regression testing:

      • Open a course
      • Turn editing on
      • Open the module chooser
      • Press the [x] button in it's top-right corner
      • Re-open the module chooser
      • Confirm that all other functionality works:
        • Pressing escape closes correctly
        • Pressing cancel closes correctly
        • Selecting an activity updates it's description
        • Selecting an activity and using the 'Add' button opens the correct page
        • Double-clicking an activity opens the correct page

      If you want extra brownie points, also apply the patch for MDL-33649 and:

      • Open a course
      • Turn editing on
      • Refresh the page (in case you already had editing on on a course page - we need to make sure we're testing on a clean slate)
        • Confirm that you can scroll the page up/down*
      • Open the activity chooser
        • Confirm that you can't scroll the page background*
      • Hit the [x] button
        • Confirm that you can scroll the page up/down*
      Show
      Regression testing: Open a course Turn editing on Open the module chooser Press the [x] button in it's top-right corner Re-open the module chooser Confirm that all other functionality works: Pressing escape closes correctly Pressing cancel closes correctly Selecting an activity updates it's description Selecting an activity and using the 'Add' button opens the correct page Double-clicking an activity opens the correct page If you want extra brownie points, also apply the patch for MDL-33649 and: Open a course Turn editing on Refresh the page (in case you already had editing on on a course page - we need to make sure we're testing on a clean slate) Confirm that you can scroll the page up/down * Open the activity chooser Confirm that you can't scroll the page background * Hit the [x] button Confirm that you can scroll the page up/down *
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33729-master-1

      Description

      Ankit found a bug in MDL-33649 whereby use of the [x] button wasn't triggering the cancel_popup() function call.
      The cancel_popup event ensures that all of the event listeners are cancelled to prevent duplicate event handles so it's important that this be added really.

        Attachments

          Issue Links

            Activity

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  25/Jun/12