Moodle
  1. Moodle
  2. MDL-33731

Clicking the [x] button on a the activity choosers shows a warning in the JS console

    Details

    • Testing Instructions:
      Hide
      • Open a course
      • Turn editing on
      • Open your JS error console
      • Open the activity chooser
      • Click the [x] button
        • Confirm no errors were shown
      • Refresh the page
      • Open the activity chooser
      • Try drag/dropping it around by it's title
        • Confirm no errors were shown
      Show
      Open a course Turn editing on Open your JS error console Open the activity chooser Click the [x] button Confirm no errors were shown Refresh the page Open the activity chooser Try drag/dropping it around by it's title Confirm no errors were shown
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33731-master-1
    • Rank:
      41762

      Description

      Following integration of MDL-33292, I've noticed a minor issue whereby if the close button is pressed, the dd handler shows a JS error.
      We just need to add an exception for the close button so that the drag/drop doesn't try to drag it.

        Activity

        Hide
        Andrew Nicols added a comment -

        Raising priority of this as it prevents users from using the [x] entirely in some browsers (mobile safari on iPad)

        Show
        Andrew Nicols added a comment - Raising priority of this as it prevents users from using the [x] entirely in some browsers (mobile safari on iPad)
        Hide
        Dan Poltawski added a comment -

        Integrated, thanks

        Show
        Dan Poltawski added a comment - Integrated, thanks
        Hide
        Dan Poltawski added a comment -

        Tested, thanks

        Show
        Dan Poltawski added a comment - Tested, thanks
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

        Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: