Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33731

Clicking the [x] button on a the activity choosers shows a warning in the JS console

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3
    • Component/s: Course, JavaScript
    • Labels:
    • Testing Instructions:
      Hide
      • Open a course
      • Turn editing on
      • Open your JS error console
      • Open the activity chooser
      • Click the [x] button
        • Confirm no errors were shown
      • Refresh the page
      • Open the activity chooser
      • Try drag/dropping it around by it's title
        • Confirm no errors were shown
      Show
      Open a course Turn editing on Open your JS error console Open the activity chooser Click the [x] button Confirm no errors were shown Refresh the page Open the activity chooser Try drag/dropping it around by it's title Confirm no errors were shown
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-33731-master-1

      Description

      Following integration of MDL-33292, I've noticed a minor issue whereby if the close button is pressed, the dd handler shows a JS error.
      We just need to add an exception for the close button so that the drag/drop doesn't try to drag it.

        Attachments

          Activity

            People

            Assignee:
            dobedobedoh Andrew Nicols
            Reporter:
            dobedobedoh Andrew Nicols
            Integrator:
            Dan Poltawski
            Tester:
            Dan Poltawski
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              25/Jun/12