Moodle
  1. Moodle
  2. MDL-33733

buggy extract_to_storage in zip_packer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.7, 2.2.4
    • Component/s: Files API
    • Labels:
    • Testing Instructions:
      Hide

      tested by phpunit tests in MDL-33710

      Show
      tested by phpunit tests in MDL-33710
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Rank:
      41765

      Description

      discovered while writing tests for MDL-33710, it fails when you tell it to extract stored_file to file storage

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          Petr, silly question... are the phpdocs for all those "extract_to_storage" methods correct? ("extract file to given file path (real OS filesystem)") ? Or I'm missing something or they are wrong (and causing some headaches here). Please, create new issue for them if necessary.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Petr, silly question... are the phpdocs for all those "extract_to_storage" methods correct? ("extract file to given file path (real OS filesystem)") ? Or I'm missing something or they are wrong (and causing some headaches here). Please, create new issue for them if necessary. Ciao
          Hide
          Eloy Lafuente (stronk7) added a comment - - edited

          Integrated (20, 21, 22 & master). I've cherry-picked this for master coz we are discussing if MDL-33710 and MDL-33753 are suitable for master hours before release.

          Edited: Finally 20_STABLE added too, it does not hurt much.

          Show
          Eloy Lafuente (stronk7) added a comment - - edited Integrated (20, 21, 22 & master). I've cherry-picked this for master coz we are discussing if MDL-33710 and MDL-33753 are suitable for master hours before release. Edited: Finally 20_STABLE added too, it does not hurt much.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          tested by running the unit tests related to this present @ MDL-33710. Passed.

          Show
          Eloy Lafuente (stronk7) added a comment - tested by running the unit tests related to this present @ MDL-33710 . Passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Yay. just in time for Moodle 2.3 release! Many thanks!

          Closing as fixed, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Yay. just in time for Moodle 2.3 release! Many thanks! Closing as fixed, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: