tested by phpunit tests in MDL-33710
discovered while writing tests for MDL-33710, it fails when you tell it to extract stored_file to file storage
moodle created zip files are not utf-8 compatible
Petr, silly question... are the phpdocs for all those "extract_to_storage" methods correct? ("extract file to given file path (real OS filesystem)") ? Or I'm missing something or they are wrong (and causing some headaches here). Please, create new issue for them if necessary.
Integrated (20, 21, 22 & master). I've cherry-picked this for master coz we are discussing if MDL-33710 and MDL-33753 are suitable for master hours before release.
Edited: Finally 20_STABLE added too, it does not hurt much.
tested by running the unit tests related to this present @ MDL-33710. Passed.
Yay. just in time for Moodle 2.3 release! Many thanks!
Closing as fixed, ciao