Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.3.1
    • Component/s: Filepicker, Resource
    • Labels:

      Description

      Currently the folder looks terrible in view mode.

      Solution 1: (quick)

      • switch to a renderer similar to tree mode in the file manager, and similar to the private files BLOCK view.

      Solution 2: (ideal)

      • combine edit and view pages into one filemanager, but designed so that there are no editing controls for people who don't have the editing capability

        Gliffy Diagrams

        1. MDL-33746-folder-patch.txt
          1 kB
          Tõnis Tartes
        1. Moodle 2.2 screenshot.jpg
          31 kB
        2. screenshot-1.jpg
          214 kB

          Issue Links

            Activity

            Hide
            marina Marina Glancy added a comment -

            Martin, is this MUST FIX? Are you joking? We discussed it couple months ago and you said it was out of scope for initial 2.3 release

            Show
            marina Marina Glancy added a comment - Martin, is this MUST FIX? Are you joking? We discussed it couple months ago and you said it was out of scope for initial 2.3 release
            Hide
            salvetore Michael de Raadt added a comment -

            This will have to wait.

            Show
            salvetore Michael de Raadt added a comment - This will have to wait.
            Hide
            dougiamas Martin Dougiamas added a comment - - edited

            Sorry it got MUST FIX automatically from the parent. But it's super horrible and I am hoping someone will fix it soon anyway.

            The renderers already exist, it's mostly a cut and paste job.

            Show
            dougiamas Martin Dougiamas added a comment - - edited Sorry it got MUST FIX automatically from the parent. But it's super horrible and I am hoping someone will fix it soon anyway. The renderers already exist, it's mostly a cut and paste job.
            Hide
            t6nis20 Tõnis Tartes added a comment - - edited

            MDL-33746 - I did a patch as the first solution was recommended. I hope this helps a bit.

            Show
            t6nis20 Tõnis Tartes added a comment - - edited MDL-33746 - I did a patch as the first solution was recommended. I hope this helps a bit.
            Hide
            dougiamas Martin Dougiamas added a comment -

            Thanks Tõnis! Marina could you review and submit?

            Show
            dougiamas Martin Dougiamas added a comment - Thanks Tõnis! Marina could you review and submit?
            Hide
            mudrd8mz David Mudrak added a comment -

            When working on it, we should consider displaying file thumbnails if they are available.

            Show
            mudrd8mz David Mudrak added a comment - When working on it, we should consider displaying file thumbnails if they are available.
            Hide
            marina Marina Glancy added a comment -

            I had to re-write the patch completely

            Show
            marina Marina Glancy added a comment - I had to re-write the patch completely
            Hide
            dougiamas Martin Dougiamas added a comment -

            Yay, nice thanks!

            Show
            dougiamas Martin Dougiamas added a comment - Yay, nice thanks!
            Hide
            mudrd8mz David Mudrak added a comment -

            Yup, something like that. Thanks a lot Marina for the prompt patch!

            Show
            mudrd8mz David Mudrak added a comment - Yup, something like that. Thanks a lot Marina for the prompt patch!
            Hide
            dougiamas Martin Dougiamas added a comment -

            Tested it on a big folder with a few hundred files and it looked really good. +1 to integrate

            Show
            dougiamas Martin Dougiamas added a comment - Tested it on a big folder with a few hundred files and it looked really good. +1 to integrate
            Hide
            wheelie1978 colin wheelhouse added a comment -

            The patch as submitted by Marina does exactly what it needs to do and looks great. Thanks to Tõnis also for the original submission. +1 to integrate also.

            Show
            wheelie1978 colin wheelhouse added a comment - The patch as submitted by Marina does exactly what it needs to do and looks great. Thanks to Tõnis also for the original submission. +1 to integrate also.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Per request, I'm going to integrate this now (23 and master). It looks way better, for sure, great path!

            Anyway, I'd recommend to "fine-tune" that tree visualization because, or I'm wrong or there is room for that yet, with things like:

            • Differences between the browse and edit modes (spacing, tree dots shown on each...)
            • Alignment of the item icons with the dots...

            For your consideration, to ignore it or create a new issue for the remaining adjustments.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Per request, I'm going to integrate this now (23 and master). It looks way better, for sure, great path! Anyway, I'd recommend to "fine-tune" that tree visualization because, or I'm wrong or there is room for that yet, with things like: Differences between the browse and edit modes (spacing, tree dots shown on each...) Alignment of the item icons with the dots... For your consideration, to ignore it or create a new issue for the remaining adjustments. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks! (23 and master)

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (23 and master)
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Looks great, passing!

            Just two side comments:

            • The minor "tuning" details I commented above.
            • Personally I hate to get everything there downloaded by default, but that's a personal opinion.

            Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Looks great, passing! Just two side comments: The minor "tuning" details I commented above. Personally I hate to get everything there downloaded by default, but that's a personal opinion. Ciao
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Congratulations your code is upstream - gold star for you!

            This issue + 79 others made it in in time for the minor releases.
            Thank you everyone involved for your exuberant efforts.

            Show
            samhemelryk Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/12