Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33748

XMLDB: xmldb_field constant CHAR_MAX_LENGTH value too low

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.3
    • Fix Version/s: None
    • Component/s: Database SQL/XMLDB
    • Labels:
      None
    • Affected Branches:
      MOODLE_23_STABLE

      Description

      See MDL-32112.

      I'd like to ask about the char/varchar column limit value CHAR_MAX_LENGTH, if I may. Why 1333? Especially in view of the docblock mentioning the four most likely to be used DB engines having a max column length well above 1333.

      Please forgive for my ignorance if it's otherwise, but is 1333 a magic number?

      I've written an enrollment plugin that makes use of staging tables to store IMS-based messages. The IMS spec has the course description max length at 2048.

      Rather than have to create a text/clob column, it is preferable I think to create a varchar2 column. I realize the likelihood of an IMS course description exceeding 1000 or so characters is slim, but not everybody adheres the specs.

      I'd like to suggest the CHAR_MAX_LENGTH value be adjusted to 4000 to match the Oracle max length.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                skodak Petr Skoda
                Reporter:
                woolardfa@appstate.edu Fred Woolard
                Participants:
                Component watchers:
                Jake Dallimore, Jun Pataleta
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: