Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33756

Prevent using converters on non-course non-general backup operations

    Details

    • Testing Instructions:
      Hide

      Note, this needs testing both under 22_STABLE and master.

      Note, 22_STABLE requires this to be setup in config.php or 4/ below won't pass:

      $CFG->enablebackupconverters = true;

      Steps:

      1/ login as admin. go to any course page having activities.
      2/ execute settings->backup.
      3/ one form of settings is shown (Backup settings).
      4/ TEST: There is one "IMS Common Cartridge 1.1" checkbox (unchecked) as the very first setting.

      5/ go back to the course page.
      6/ go to any activity.
      7/ execute settings->backup.
      8/ one form of settings is shown.
      9/ TEST: There IS NOT one "IMS Common Cartridge 1.1" checkbox.

      10/ go back to the course page.
      11/ execute settings->import.
      12/ one form of settings is shown.
      13/ TEST: There IS NOT one "IMS Common Cartridge 1.1" checkbox.

      14/ go back to the course page.
      15/ enable edition.
      16/ click on the "x2" (duplicate) icon for any activity.
      17/ TEST: There IS NOT one "IMS Common Cartridge 1.1" checkbox along the whole duplication process.

      Optionally (if the site has some hub defined):

      18/ go back to the course page.
      19/ execute settings->publish.
      20/ TEST: There IS NOT one "IMS Common Cartridge 1.1" checkbox along the whole publish process.

      Show
      Note, this needs testing both under 22_STABLE and master. Note, 22_STABLE requires this to be setup in config.php or 4/ below won't pass: $CFG->enablebackupconverters = true; Steps: 1/ login as admin. go to any course page having activities. 2/ execute settings->backup. 3/ one form of settings is shown (Backup settings). 4/ TEST: There is one "IMS Common Cartridge 1.1" checkbox (unchecked) as the very first setting. 5/ go back to the course page. 6/ go to any activity. 7/ execute settings->backup. 8/ one form of settings is shown. 9/ TEST: There IS NOT one "IMS Common Cartridge 1.1" checkbox. 10/ go back to the course page. 11/ execute settings->import. 12/ one form of settings is shown. 13/ TEST: There IS NOT one "IMS Common Cartridge 1.1" checkbox. 14/ go back to the course page. 15/ enable edition. 16/ click on the "x2" (duplicate) icon for any activity. 17/ TEST: There IS NOT one "IMS Common Cartridge 1.1" checkbox along the whole duplication process. Optionally (if the site has some hub defined): 18/ go back to the course page. 19/ execute settings->publish. 20/ TEST: There IS NOT one "IMS Common Cartridge 1.1" checkbox along the whole publish process.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Right now the available backup converters (imscc) are shown in all backup interactive operations:

      • course backups.
      • activity backups.
      • import facility.
      • publish facility.

      This is about to restrict the use of converters exclusively to course backup operations of type general. Any other operation won't have any conversion available.

        Gliffy Diagrams

          Activity

          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Sending to integration, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Sending to integration, ciao
          Hide
          poltawski Dan Poltawski added a comment -

          Integrated, thanks

          Show
          poltawski Dan Poltawski added a comment - Integrated, thanks
          Hide
          poltawski Dan Poltawski added a comment -

          And passed!

          Show
          poltawski Dan Poltawski added a comment - And passed!
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL

          Ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - Big thanks for the effort. This is now part of Moodle upstream. Let's wait for regressions, yay! LOL Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                9/Jul/12