Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33757

sorting by email address doesn't work (gradebook)

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.2.3
    • Fix Version/s: 2.2.4, 2.3.1
    • Component/s: Gradebook
    • Labels:

      Description

      Sorting by email address (click "Email address") doesn't work on any gradebook.

      (1) Open any course
      (2) Click "Grades"
      (3) Click "Email address" to sort

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            topstone ISHIKAWA Takayuki added a comment -

            screenshot (patched code)

            Show
            topstone ISHIKAWA Takayuki added a comment - screenshot (patched code)
            Hide
            salvetore Michael de Raadt added a comment -

            Hi.

            I tried this and email sorting seemed to work for me. Also, your screenshot seems to show sorted addresses also.

            Show
            salvetore Michael de Raadt added a comment - Hi. I tried this and email sorting seemed to work for me. Also, your screenshot seems to show sorted addresses also.
            Hide
            topstone ISHIKAWA Takayuki added a comment - - edited

            Sorry, the previous screenshot was after applying the patch file. Here is new screenshot.

            left : not applied the patch file
            right : applied the patch file

            Show
            topstone ISHIKAWA Takayuki added a comment - - edited Sorry, the previous screenshot was after applying the patch file. Here is new screenshot. left : not applied the patch file right : applied the patch file
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for supplying those extra details.

            Show
            salvetore Michael de Raadt added a comment - Thanks for supplying those extra details.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Ishikawa,
            Thanks for the patch.
            Changes looks good to me.
            Sending this for peer review.

            @integrator
            This is a clean pick to 22 and 23

            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Ishikawa, Thanks for the patch. Changes looks good to me. Sending this for peer review. @integrator This is a clean pick to 22 and 23 Thanks
            Hide
            andyjdavis Andrew Davis added a comment -

            Looks simple enough. You are go for integration.

            Show
            andyjdavis Andrew Davis added a comment - Looks simple enough. You are go for integration.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Thanks Andrew for the review.
            Submitting for integration.
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Thanks Andrew for the review. Submitting for integration. Thanks
            Hide
            poltawski Dan Poltawski added a comment -

            Hi,

            This commit doesn't have an bug number. Ankit - any chance you could ammend the commit to add that?

            Show
            poltawski Dan Poltawski added a comment - Hi, This commit doesn't have an bug number. Ankit - any chance you could ammend the commit to add that?
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            Hi Dan,
            I have pulled the commit to my repo and have edited the commit msg.
            Let me know if anything else needs changed.
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - Hi Dan, I have pulled the commit to my repo and have edited the commit msg. Let me know if anything else needs changed. Thanks
            Hide
            poltawski Dan Poltawski added a comment -

            Perfect, thanks Ankit.

            I've integrated this to master, 23, 22 - thanks

            Show
            poltawski Dan Poltawski added a comment - Perfect, thanks Ankit. I've integrated this to master, 23, 22 - thanks
            Hide
            andyjdavis Andrew Davis added a comment -

            Works as described. Passing.

            Show
            andyjdavis Andrew Davis added a comment - Works as described. Passing.
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Congratulations your code is upstream - gold star for you!

            This issue + 79 others made it in in time for the minor releases.
            Thank you everyone involved for your exuberant efforts.

            Show
            samhemelryk Sam Hemelryk added a comment - Congratulations your code is upstream - gold star for you! This issue + 79 others made it in in time for the minor releases. Thank you everyone involved for your exuberant efforts.

              People

              • Votes:
                3 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  9/Jul/12