Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-33765

Glossary filter JS popup uselessly links to itself for recursive glossary entry

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3, 2.7.3, 2.8.1, 2.8.6, 2.9
    • 2.8.7, 2.9.1
    • Glossary
    • MOODLE_23_STABLE, MOODLE_27_STABLE, MOODLE_28_STABLE, MOODLE_29_STABLE
    • MOODLE_28_STABLE, MOODLE_29_STABLE
    • MDL-33765_master_offset
    • Hide
      Test 1
      1. Enable the glossary filter via Site administration > Plugins > Filters > Manage filters.
      2. Create two glossary entries that contain the definition and link to each other (ensure both have 'This entry should be automatically linked' checked). Example - 

        Concept: Moodle
        		 
        Definition: Moodle is better than Blackboard
        		 
         
        		 
        Concept: Blackboard
        		 
        Definition: Blackboard is not as good as Moodle

      3. Edit a course section and add the concepts to the description.
      4. Click on one link and ensure it shows one JS popup with the definition of the concept.
      5. Make sure that concept is not linked to itself in popup, ie is not clickable.
      6. Click on the link of the other concept in the pop-up and ensure another pop-up is created with a slight offset.
      Test 2
      1. Repeat the above on a few mobile devices and ensure all is good.
      Show
      Test 1 Enable the glossary filter via Site administration > Plugins > Filters > Manage filters. Create two glossary entries that contain the definition and link to each other (ensure both have 'This entry should be automatically linked' checked). Example - Concept: Moodle Definition: Moodle is better than Blackboard   Concept: Blackboard Definition: Blackboard is not as good as Moodle Edit a course section and add the concepts to the description. Click on one link and ensure it shows one JS popup with the definition of the concept. Make sure that concept is not linked to itself in popup, ie is not clickable. Click on the link of the other concept in the pop-up and ensure another pop-up is created with a slight offset. Test 2 Repeat the above on a few mobile devices and ensure all is good.

    Description

      As discovered in MDL-32279. The JS popup to a glossary entry is filtered, causing a link to itself.

      Replication steps:

      1. Enable glossary filter @ admin->plugins->filters->manage. (set to content and headings)
      2. Create one glossary entry with the definition containing the concept
      3. Create one forum post containing some of the concepts created in 3/. Save it.
      4. Clicking the link shows one JS popup with the definition of the concept

      Expected result:
      The concept is not linked to itself in the JS popup definition

      Actual result:
      The concept is linked to itself in the JS popup definition

      Attachments

        Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-51075 Glossary popup position same for all popups - need to scroll up/down to find the popup

          • Major - Major loss of function, incorrect output
          • Closed
          Testing discovered

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-32279 Text caching leads to missing inclusion of JS/YUI required stuff

          • Critical - Crashes server, loss of data, severe memory leak
          • Closed

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-50438 Missing exception classes in autolinker.js

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              mastnym Martin Mastny
              poltawski Dan Poltawski
              Mark Nelson Mark Nelson
              Dan Poltawski Dan Poltawski
              Simey Lameze Simey Lameze
              Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                6/Jul/15